mirror of
https://github.com/KelvinTegelaar/CIPP.git
synced 2026-04-25 08:16:01 +03:00
[GH-ISSUE #2] Known issue: Menu header does not always change based on page you are at. #1
Labels
No labels
API
Feature
NotABug
NotABug
Planned
Sponsor Priority
Sponsor Priority
bug
documentation
duplicate
enhancement
needs more info
no-activity
no-priority
not-assigned
pull-request
react-conversion
react-conversion
roadmap
security
stale
unconfirmed-by-user
unconfirmed-by-user
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/CIPP#1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @KelvinTegelaar on GitHub (Oct 14, 2021).
Original GitHub issue: https://github.com/KelvinTegelaar/CIPP/issues/2
Originally assigned to: @redanthrax, @KelvinTegelaar on GitHub.
Describe the bug
When changing the pages via a
<SpecialNavLink>the active marker of the page does not change.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Menu item must change
Additional context
This is a known issue, will be worked on.
@redanthrax commented on GitHub (Oct 15, 2021):
I'm working on this.
@redanthrax commented on GitHub (Oct 15, 2021):
#27
@KelvinTegelaar commented on GitHub (Oct 16, 2021):
@redanthrax Was that release supposed to fix it? I think you might've wanted to target another issue. :)
@redanthrax commented on GitHub (Oct 18, 2021):
@KelvinTegelaar I think you're right!
@redanthrax commented on GitHub (Oct 18, 2021):
@KelvinTegelaar Can you validate this is still a bug?
@KelvinTegelaar commented on GitHub (Oct 18, 2021):
Yes, just did a test, switching from "Tenant Administration -> Tenants" to "List Standards" keeps "Tenants" selected.
@redanthrax commented on GitHub (Oct 19, 2021):
This should have been fixed in PR #74 @KelvinTegelaar
nvm i am dumb fixed in the below PR
@KelvinTegelaar commented on GitHub (Oct 20, 2021):
@redanthrax freaking beautiful, loving how it doesn't "jump" but moves smoothly. Thank you.