[PR #833] [MERGED] Fix tag color error #937

New issue

Closed

opened 2026-03-03 00:23:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:23:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/833
Author: @Komediruzecki
Created: 3/7/2021
Status: ✅ Merged
Merged: 3/7/2021
Merged by: @Rokt33r

Base: master ← Head: bugfix/tag-color-nav-list

📝 Commits (1)

1d52355 Fix tag color error

📊 Changes

1 file changed (+6 additions, -10 deletions)

View changed files

📝 src/components/atoms/TagNavigatorListItem.tsx (+6 -10)

📄 Description

Fix tag color error

When tag.data.color is set in TagNavigatorListItem the react
is throwing error that object is not extensible, in general there should be no
updating of props

Maybe there is better solution, to just assign to an object i.e. extend it somehow, but in general I think this is ok solution, since props should be in a way frozen.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/833 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 3/7/2021 **Status:** ✅ Merged **Merged:** 3/7/2021 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `bugfix/tag-color-nav-list` --- ### 📝 Commits (1) - [`1d52355`](https://github.com/BoostIO/BoostNote-App/commit/1d5235542585298a72b37ec571c2adeed75962db) Fix tag color error ### 📊 Changes **1 file changed** (+6 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/components/atoms/TagNavigatorListItem.tsx` (+6 -10) </details> ### 📄 Description **Fix tag color error** When tag.data.color is set in TagNavigatorListItem the react is throwing error that object is not extensible, in general there should be no updating of props Maybe there is better solution, to just assign to an object i.e. extend it somehow, but in general I think this is ok solution, since props should be in a way frozen. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:23:53 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:24:16 +03:00

[PR #937] [MERGED] UI: Removed Border Radius from Context Menu on Top Bar #1018

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#937

No description provided.

Rows
Columns