[PR #744] [MERGED] Fix attachment urls being revoked too early #877

New issue

Closed

opened 2026-03-03 00:23:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:23:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/744
Author: @Komediruzecki
Created: 12/25/2020
Status: ✅ Merged
Merged: 12/31/2020
Merged by: @Rokt33r

Base: master ← Head: bugfix/pdf-attachment-export-duplicate-attachments

📝 Commits (3)

446a1ab Fix attachment urls being revoked too early
12a50b5 Refactor attachments revoking
c843b15 Improve naming of variables

📊 Changes

2 files changed (+27 additions, -20 deletions)

View changed files

📝 src/components/organisms/NotePageToolbar.tsx (+3 -2)
📝 src/lib/exports.ts (+24 -18)

📄 Description

Fix attachment urls being revoked too early (#745 )

Fix parse.path to be able to test new PDF export
Update attachment logic to filter out duplicates
Fix attachment URLs being revoked too early

Test

In electron Linux App (dev)
In electron Linux App production version (appImage)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/744 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 12/25/2020 **Status:** ✅ Merged **Merged:** 12/31/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `bugfix/pdf-attachment-export-duplicate-attachments` --- ### 📝 Commits (3) - [`446a1ab`](https://github.com/BoostIO/BoostNote-App/commit/446a1abb0d607fff4c7793591b83bb8bbde9c611) Fix attachment urls being revoked too early - [`12a50b5`](https://github.com/BoostIO/BoostNote-App/commit/12a50b52d46439c84e2ebb4c36bc11c7f9663d9a) Refactor attachments revoking - [`c843b15`](https://github.com/BoostIO/BoostNote-App/commit/c843b15a557bcea88a3ec41dba9d0a37f2b8fc1a) Improve naming of variables ### 📊 Changes **2 files changed** (+27 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/components/organisms/NotePageToolbar.tsx` (+3 -2) 📝 `src/lib/exports.ts` (+24 -18) </details> ### 📄 Description **Fix attachment urls being revoked too early** (#745 ) Fix ```parse.path``` to be able to test new PDF export Update attachment logic to filter out duplicates Fix attachment URLs being revoked too early Test - In electron Linux App (dev) - In electron Linux App production version (appImage) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:23:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:24:01 +03:00

[PR #877] [MERGED] UI: Restyled Backlink #967

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#877

No description provided.

Rows
Columns