[PR #741] [CLOSED] Fix bug for saving document with shortcut (ctrl+s) #876

New issue

Closed

opened 2026-03-03 00:23:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:23:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/741
Author: @Komediruzecki
Created: 12/25/2020
Status: ❌ Closed

Base: master ← Head: bugfix/save-shortcut

📝 Commits (1)

cb870ba Add parse path import

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 src/components/organisms/NotePageToolbar.tsx (+3 -2)

📄 Description

Add parsePath import (fix for: #742)

Fix a bug where path.parse is not available in current node version
Add parsePath instead of path.parse

The save command now does not throw error on save, but better solution could be to use path.parse from newer node. Can we update it?

Todo:

After operation is finished, it would be nice to show user a push message/notification of the successfuly/failed export

Test

In electron Linux App (dev)
In electron Linux App production version (appImage)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/741 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 12/25/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix/save-shortcut` --- ### 📝 Commits (1) - [`cb870ba`](https://github.com/BoostIO/BoostNote-App/commit/cb870badb215678404abcec02c1836bba7d5edac) Add parse path import ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/components/organisms/NotePageToolbar.tsx` (+3 -2) </details> ### 📄 Description **Add parsePath import** (fix for: #742) - Fix a bug where path.parse is not available in current node version - Add parsePath instead of path.parse The save command now does not throw error on save, but better solution could be to use path.parse from newer node. Can we update it? Todo: - [ ] After operation is finished, it would be nice to show user a push message/notification of the successfuly/failed export Test - In electron Linux App (dev) - In electron Linux App production version (appImage) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:23:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:24:00 +03:00

[PR #876] [MERGED] Fix draggable area of cloud space #966

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#876

No description provided.

Rows
Columns