[PR #730] [MERGED] Allow renaming tags #869

Closed
opened 2026-03-03 00:23:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/730
Author: @guneskaan
Created: 12/20/2020
Status: Merged
Merged: 1/2/2021
Merged by: @Rokt33r

Base: masterHead: allow-renaming-tags


📝 Commits (6)

  • 16aafea Add 'Rename Tag' Button
  • cc5b338 Implement Rename Tag Functionality
  • 9d4fb6c Implement RenameTag in PouchDB
  • bc43d29 Add RenameTag Tests to Store and PouchDB
  • 9c370f5 Add Control Navigator Button to TagListFragment
  • 9d73bf0 Refactor TagListFragment

📊 Changes

10 files changed (+316 additions, -56 deletions)

View changed files

📝 src/components/molecules/TagListFragment.tsx (+99 -56)
📝 src/lib/analytics.ts (+1 -0)
📝 src/lib/db/FSNoteDb.ts (+18 -0)
📝 src/lib/db/NoteDb.ts (+1 -0)
📝 src/lib/db/PouchNoteDb.spec.ts (+34 -0)
📝 src/lib/db/PouchNoteDb.ts (+25 -0)
📝 src/lib/db/createStore.ts (+59 -0)
📝 src/lib/db/store.spec.ts (+75 -0)
📝 src/lib/db/types.ts (+2 -0)
📝 src/locales/enUS.ts (+2 -0)

📄 Description

Allow renaming tags as requested in #324 (https://github.com/BoostIO/BoostNote.next/projects/3#card-33058499).
Screen Shot 2020-12-21 at 10 13 43 AM

This feature also adds Control button to TagListFragment, meaning that three vertical dots will appear next to the tags in the list menu, showing 'Rename Tag' and 'Remove Tag' options. This way, web browser users will be able to rename tags, because they cannot right click on the tag list item.

Also added analytics event renameTag: 'tags.rename for tracking.

Added automated tests to store.spec.ts and PouchNoteDb.spec.ts to verify renaming functionality.

Manually tested:

  • Renaming tags in local PouchDB storage, reload and sync.
  • Renaming tags in cloud PouchDB storage, reload and sync.
  • Renaming tags in FS storage, reload.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/730 **Author:** [@guneskaan](https://github.com/guneskaan) **Created:** 12/20/2020 **Status:** ✅ Merged **Merged:** 1/2/2021 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `allow-renaming-tags` --- ### 📝 Commits (6) - [`16aafea`](https://github.com/BoostIO/BoostNote-App/commit/16aafeab9a614911e746e337b2fd66f12d26ee1b) Add 'Rename Tag' Button - [`cc5b338`](https://github.com/BoostIO/BoostNote-App/commit/cc5b338b5901df50668a22dccd822f096b401405) Implement Rename Tag Functionality - [`9d4fb6c`](https://github.com/BoostIO/BoostNote-App/commit/9d4fb6c771aa525c9c4482683cd6ebf743a65360) Implement RenameTag in PouchDB - [`bc43d29`](https://github.com/BoostIO/BoostNote-App/commit/bc43d298848a164894b9d4e52b32ea09d7397e48) Add RenameTag Tests to Store and PouchDB - [`9c370f5`](https://github.com/BoostIO/BoostNote-App/commit/9c370f506722e38ab7c524fdb627bf2433528619) Add Control Navigator Button to TagListFragment - [`9d73bf0`](https://github.com/BoostIO/BoostNote-App/commit/9d73bf0a50e0395a4f4994661bd1e22be73390aa) Refactor TagListFragment ### 📊 Changes **10 files changed** (+316 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/components/molecules/TagListFragment.tsx` (+99 -56) 📝 `src/lib/analytics.ts` (+1 -0) 📝 `src/lib/db/FSNoteDb.ts` (+18 -0) 📝 `src/lib/db/NoteDb.ts` (+1 -0) 📝 `src/lib/db/PouchNoteDb.spec.ts` (+34 -0) 📝 `src/lib/db/PouchNoteDb.ts` (+25 -0) 📝 `src/lib/db/createStore.ts` (+59 -0) 📝 `src/lib/db/store.spec.ts` (+75 -0) 📝 `src/lib/db/types.ts` (+2 -0) 📝 `src/locales/enUS.ts` (+2 -0) </details> ### 📄 Description Allow renaming tags as requested in #324 (https://github.com/BoostIO/BoostNote.next/projects/3#card-33058499). <img width="410" alt="Screen Shot 2020-12-21 at 10 13 43 AM" src="https://user-images.githubusercontent.com/14365429/102750034-2cb20c00-4376-11eb-93f0-5a16ed060ea3.png"> This feature also adds `Control` button to `TagListFragment`, meaning that three vertical dots will appear next to the tags in the list menu, showing 'Rename Tag' and 'Remove Tag' options. This way, web browser users will be able to rename tags, because they cannot right click on the tag list item. Also added analytics event `renameTag: 'tags.rename` for tracking. Added automated tests to `store.spec.ts` and `PouchNoteDb.spec.ts` to verify renaming functionality. Manually tested: - Renaming tags in local PouchDB storage, reload and sync. - Renaming tags in cloud PouchDB storage, reload and sync. - Renaming tags in FS storage, reload. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:23:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#869
No description provided.