mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-26 21:05:55 +03:00
[PR #730] [MERGED] Allow renaming tags #869
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#869
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/730
Author: @guneskaan
Created: 12/20/2020
Status: ✅ Merged
Merged: 1/2/2021
Merged by: @Rokt33r
Base:
master← Head:allow-renaming-tags📝 Commits (6)
16aafeaAdd 'Rename Tag' Buttoncc5b338Implement Rename Tag Functionality9d4fb6cImplement RenameTag in PouchDBbc43d29Add RenameTag Tests to Store and PouchDB9c370f5Add Control Navigator Button to TagListFragment9d73bf0Refactor TagListFragment📊 Changes
10 files changed (+316 additions, -56 deletions)
View changed files
📝
src/components/molecules/TagListFragment.tsx(+99 -56)📝
src/lib/analytics.ts(+1 -0)📝
src/lib/db/FSNoteDb.ts(+18 -0)📝
src/lib/db/NoteDb.ts(+1 -0)📝
src/lib/db/PouchNoteDb.spec.ts(+34 -0)📝
src/lib/db/PouchNoteDb.ts(+25 -0)📝
src/lib/db/createStore.ts(+59 -0)📝
src/lib/db/store.spec.ts(+75 -0)📝
src/lib/db/types.ts(+2 -0)📝
src/locales/enUS.ts(+2 -0)📄 Description
Allow renaming tags as requested in #324 (https://github.com/BoostIO/BoostNote.next/projects/3#card-33058499).

This feature also adds
Controlbutton toTagListFragment, meaning that three vertical dots will appear next to the tags in the list menu, showing 'Rename Tag' and 'Remove Tag' options. This way, web browser users will be able to rename tags, because they cannot right click on the tag list item.Also added analytics event
renameTag: 'tags.renamefor tracking.Added automated tests to
store.spec.tsandPouchNoteDb.spec.tsto verify renaming functionality.Manually tested:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.