[PR #706] [MERGED] Preserve Note Creation and Last Updated Times when Importing from Legacy (#631) #855

Closed
opened 2026-03-03 00:23:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/706
Author: @guneskaan
Created: 12/1/2020
Status: Merged
Merged: 12/6/2020
Merged by: @Rokt33r

Base: masterHead: preserve-note-creation-times-on-import


📝 Commits (1)

  • de2d256 Preserve Note Creation and Last Updated Time when Importing from Legacy

📊 Changes

4 files changed (+19 additions, -6 deletions)

View changed files

📝 src/components/organisms/ImportLegacyNotesForm.tsx (+9 -3)
📝 src/lib/db/FSNoteDb.ts (+3 -2)
📝 src/lib/db/createStore.ts (+2 -1)
📝 src/lib/db/types.ts (+5 -0)

📄 Description

Fixes #631.

Currently we do not read createdAt or updatedAt props when importing notes from legacy.
Added noteDocImportableProps type, since adding createdAt and updatedAt props to noteDocEditibleProps doesn't sound right.

Changed createNote functions to accept either imported props or editable partial props.

Tested the following cases after importing notes from legacy:

  • Confirmed the creation date and last update date are preserved.
  • Confirmed that last update date is changed when I edit the note and save.
  • Confirmed that I can create notes manually, and creation date and last update date are set to now.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/706 **Author:** [@guneskaan](https://github.com/guneskaan) **Created:** 12/1/2020 **Status:** ✅ Merged **Merged:** 12/6/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `preserve-note-creation-times-on-import` --- ### 📝 Commits (1) - [`de2d256`](https://github.com/BoostIO/BoostNote-App/commit/de2d256b5ab066bb70de2257c4da24434fec09f0) Preserve Note Creation and Last Updated Time when Importing from Legacy ### 📊 Changes **4 files changed** (+19 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/components/organisms/ImportLegacyNotesForm.tsx` (+9 -3) 📝 `src/lib/db/FSNoteDb.ts` (+3 -2) 📝 `src/lib/db/createStore.ts` (+2 -1) 📝 `src/lib/db/types.ts` (+5 -0) </details> ### 📄 Description Fixes #631. Currently we do not read `createdAt` or `updatedAt` props when importing notes from legacy. Added `noteDocImportableProps` type, since adding `createdAt` and `updatedAt` props to `noteDocEditibleProps` doesn't sound right. Changed `createNote` functions to accept either imported props or editable partial props. Tested the following cases after importing notes from legacy: - Confirmed the creation date and last update date are preserved. - Confirmed that last update date is changed when I edit the note and save. - Confirmed that I can create notes manually, and creation date and last update date are set to now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:23:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#855
No description provided.