starred/BoostNote-App

Fork 0

mirror of https://github.com/BoostIO/BoostNote-App.git synced 2026-04-26 21:05:55 +03:00

[PR #681] [MERGED] Add Codemirror search functionality (#219, #629) #840

New issue

Closed

opened 2026-03-03 00:23:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:23:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/681
Author: @Komediruzecki
Created: 11/13/2020
Status: ✅ Merged
Merged: 11/21/2020
Merged by: @Rokt33r

Base: master ← Head: feature/add-search-and-replace-in-editor

📝 Commits (2)

c66f197 Add Codemirror search functionality
d19380e Change replace shortcut key(Alt-F -> Cmd,Ctrl-Alt-F)

📊 Changes

4 files changed (+40 additions, -11 deletions)

View changed files

📝 package-lock.json (+9 -9)
📝 package.json (+2 -2)
📝 src/components/atoms/CodeEditor.tsx (+24 -0)
📝 src/lib/CodeMirror.ts (+5 -0)

📄 Description

Add Codemirror search functionality (c66f197244) (#219, #629)

Update Codemirror to latest
Update Codemirror typings to latest
Add code mirror search functionality (include needed addons)
Add some styling of replace search buttons by adding css to StyledContainer in CodeEditor
Add extraKeys: esc when search dialog found something and marked it - to clear the serach contents (without need of calling the serach again)
Add extraKeys: Alt+F - persistant find/search to have dialog persistent while searching

Test:
In electron Linux App (dev)
In electron Linux App production version (appImage)

Todo:

Fix styling of search and replace navigation buttons when on light editor backgrounds (invert colors?)
Advanced search functionality
- An option to select, so it only searches titles of notes, instead of contents and notes simultaneously.
Add search content in ctrl+p search notes functionality?

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

#219: Search within editor

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/681 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 11/13/2020 **Status:** ✅ Merged **Merged:** 11/21/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `feature/add-search-and-replace-in-editor` --- ### 📝 Commits (2) - [`c66f197`](https://github.com/BoostIO/BoostNote-App/commit/c66f1972445a069bb888479b7b50b7cbc91edda0) Add Codemirror search functionality - [`d19380e`](https://github.com/BoostIO/BoostNote-App/commit/d19380e5be953fc969a5cd93f326dc9f6dfd6594) Change replace shortcut key(Alt-F -> Cmd,Ctrl-Alt-F) ### 📊 Changes **4 files changed** (+40 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+9 -9) 📝 `package.json` (+2 -2) 📝 `src/components/atoms/CodeEditor.tsx` (+24 -0) 📝 `src/lib/CodeMirror.ts` (+5 -0) </details> ### 📄 Description **Add Codemirror search functionality** (c66f1972445a069bb888479b7b50b7cbc91edda0) (#219, #629) Update Codemirror to latest Update Codemirror typings to latest Add code mirror search functionality (include needed addons) Add some styling of replace search buttons by adding css to StyledContainer in CodeEditor Add extraKeys: esc when search dialog found something and marked it - to clear the serach contents (without need of calling the serach again) Add extraKeys: Alt+F - persistant find/search to have dialog persistent while searching **Test:** In electron Linux App (dev) In electron Linux App production version (appImage) ### Todo: - [ ] Fix styling of search and replace navigation buttons when on light editor backgrounds (invert colors?) - [ ] Advanced search functionality - An option to select, so it only searches titles of notes, instead of contents and notes simultaneously. - [ ] Add search content in ctrl+p search notes functionality?  --- <details> <summary> <b>IssueHunt Summary</b> </summary> ### Referenced issues This pull request has been submitted to: - [#219: Search within editor](https://issuehunt.io/repos/74213528/issues/219) --- </details>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:23:26 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:23:55 +03:00

[PR #840] [MERGED] add forced event sending #944

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#840

No description provided.

Rows
Columns