[PR #477] [CLOSED] Fixed style bugs on tags | #330 #769

New issue

Closed

opened 2026-03-03 00:23:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:23:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/477
Author: @jhdcruz
Created: 5/14/2020
Status: ❌ Closed

Base: master ← Head: tags_bugfix

📝 Commits (4)

c5bbe8a added 'maxLength' for immortal tags
78168af prevent word-break on tagInput
fdb2f02 fixed conflicts
91f86ba Merge branch 'master' into tags_bugfix

📊 Changes

1 file changed (+13 additions, -21 deletions)

View changed files

📝 src/components/organisms/NoteDetail.tsx (+13 -21)

📄 Description

Description

Fix style bugs on tags:

Prevent word-break on CN, KR and other characters.
Add maxLength to prevent "immortal" tags. (conflicts with the new update)

Addresses Issue #330

c5bbe8ae3a:
~~Max length on tags~~
I set maxLength to 25 after testing LLLLLL...., TTTTTT.... wide letters on it and came to a conclusion to set it to 25. This is a possible fix to the problem of immortal tags.

~~Personally, I think this is a good move to prevent long tag abuse (although I know it's the user's decision).~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/477 **Author:** [@jhdcruz](https://github.com/jhdcruz) **Created:** 5/14/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `tags_bugfix` --- ### 📝 Commits (4) - [`c5bbe8a`](https://github.com/BoostIO/BoostNote-App/commit/c5bbe8ae3adff183c09acfe6e33f8a6abecaff45) added 'maxLength' for immortal tags - [`78168af`](https://github.com/BoostIO/BoostNote-App/commit/78168af62640d69104b0f3961be62da51a844c67) prevent word-break on tagInput - [`fdb2f02`](https://github.com/BoostIO/BoostNote-App/commit/fdb2f026f073a1a24f2fb482c2d391a7cba3fc2c) fixed conflicts - [`91f86ba`](https://github.com/BoostIO/BoostNote-App/commit/91f86ba350330a57c17e779caba80ce54e38df84) Merge branch 'master' into tags_bugfix ### 📊 Changes **1 file changed** (+13 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/components/organisms/NoteDetail.tsx` (+13 -21) </details> ### 📄 Description ## Description Fix style bugs on tags: - [x] Prevent word-break on `CN`, `KR` and other characters. - [ ] Add `maxLength` to prevent _"immortal"_ tags. **(conflicts with the new update)** **Addresses Issue #330** -------- c5bbe8ae3adff183c09acfe6e33f8a6abecaff45: ~~**Max length on tags**~~ ~~I set `maxLength` to `25` after testing `LLLLLL....`, `TTTTTT....` wide letters on it and came to a conclusion to set it to `25`. **This is a possible fix to the problem of immortal tags.**~~ ~~Personally, I think this is a good move to prevent long tag abuse (although I know it's the user's decision).~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:23:07 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#769

No description provided.

Rows
Columns