[PR #378] [MERGED] Fix broken build #737

Closed
opened 2026-03-03 00:22:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/378
Author: @sbencoding
Created: 3/23/2020
Status: Merged
Merged: 3/26/2020
Merged by: @Rokt33r

Base: masterHead: master


📝 Commits (3)

  • 981da7a Make build work
  • 0992f1e Instruction about .env file for build
  • 0b9250b Merge branch 'master' into master

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 readme.md (+2 -0)

📄 Description

Hi!
I tried to build the project but ran into several problems.
In this PR I post the changes I've made to be able to build the project.

  1. The Spanish locale file was renamed from esEs.ts to esES.ts because src/lib/i18n.ts referenced the file with the big S at the end.
  2. The build doesn't run without a .env file in the project root. So contributors would need to create an empty one for the build to run. I'm not really familiar with the .env system used here, so I guess you could provide a better documentation for this problem than I did. My understanding is that you use that file for storing tokens for analytics but I didn't investigate it thoroughly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/378 **Author:** [@sbencoding](https://github.com/sbencoding) **Created:** 3/23/2020 **Status:** ✅ Merged **Merged:** 3/26/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`981da7a`](https://github.com/BoostIO/BoostNote-App/commit/981da7ae70e106c219ebe4d30b29f2fb9b92f404) Make build work - [`0992f1e`](https://github.com/BoostIO/BoostNote-App/commit/0992f1e24b43f40fb7cc3ec7d21a7d95b6113843) Instruction about .env file for build - [`0b9250b`](https://github.com/BoostIO/BoostNote-App/commit/0b9250b91ed50c2db3b385f9ce047b76f79b9c90) Merge branch 'master' into master ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `readme.md` (+2 -0) </details> ### 📄 Description Hi! I tried to build the project but ran into several problems. In this PR I post the changes I've made to be able to build the project. 1. The Spanish locale file was renamed from `esEs.ts` to `esES.ts` because `src/lib/i18n.ts` referenced the file with the big *S* at the end. 2. The build doesn't run without a `.env` file in the project root. So contributors would need to create an empty one for the build to run. I'm not really familiar with the `.env` system used here, so I guess you could provide a better documentation for this problem than I did. My understanding is that you use that file for storing tokens for analytics but I didn't investigate it thoroughly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:22:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#737
No description provided.