[PR #374] [MERGED] Add Emoji support #735

Closed
opened 2026-03-03 00:22:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/374
Author: @AWolf81
Created: 3/14/2020
Status: Merged
Merged: 4/2/2020
Merged by: @Rokt33r

Base: masterHead: feat-emoji-support-245


📝 Commits (3)

  • cb95cf3 add remark-emoji
  • 9a6c57f update remark-emoji & enable emoticon support
  • d1f35f2 Merge branch 'master' into feat-emoji-support-245

📊 Changes

4 files changed (+50 additions, -1 deletions)

View changed files

📝 package-lock.json (+46 -1)
📝 package.json (+1 -0)
📝 src/components/atoms/MarkdownPreviewer.tsx (+2 -0)
📝 typings/unified.d.ts (+1 -0)

📄 Description

Issue #245

Description
I've added remark-emoji.

An example markdown is:

Hey there :+1:

I :heart: Emojis

Which renders like this:
grafik

Tested

  • Windows 10 64bit Desktop (working)
  • Linux Ubuntu (test outstanding)
  • MacOS (I need help here - I don't have a Mac here)
  • Dev mobile (working)
  • WebApp (working)
  • Emojis from https://markdown-it.github.io/ rendering (except shortcodes)

Notes

  • Emoticons like :-) are not supported. I'll check if remark-emoticon could be used. OK, I've checked this and remark-emoticon is not what I want to use - adding own images is too complicated. retext-emoji is better than remark-emoji and also supporting short-codes like :-) (see demo). But I couldn't get remark2retext to work. I think I'll write a remark-plugin that is using emoticon for shortcode handling. Or am I missing something?
  • Emoticons will be supported with an update of remark-emoji. If the following PR is merged.

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/374 **Author:** [@AWolf81](https://github.com/AWolf81) **Created:** 3/14/2020 **Status:** ✅ Merged **Merged:** 4/2/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `feat-emoji-support-245` --- ### 📝 Commits (3) - [`cb95cf3`](https://github.com/BoostIO/BoostNote-App/commit/cb95cf3e8f4ff23cd13809fd8f52de6b7b97c241) add remark-emoji - [`9a6c57f`](https://github.com/BoostIO/BoostNote-App/commit/9a6c57f420eadf1aaa2365b6d015844ae7b1ce99) update remark-emoji & enable emoticon support - [`d1f35f2`](https://github.com/BoostIO/BoostNote-App/commit/d1f35f27b25575030d761fc2469502edaffb9baf) Merge branch 'master' into feat-emoji-support-245 ### 📊 Changes **4 files changed** (+50 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+46 -1) 📝 `package.json` (+1 -0) 📝 `src/components/atoms/MarkdownPreviewer.tsx` (+2 -0) 📝 `typings/unified.d.ts` (+1 -0) </details> ### 📄 Description **Issue** #245 **Description** I've added [remark-emoji](https://www.npmjs.com/package/remark-emoji). An example markdown is: ```md Hey there :+1: I :heart: Emojis ``` Which renders like this: ![grafik](https://user-images.githubusercontent.com/3046542/76680215-173dd380-65e7-11ea-8aba-c94fed600e98.png) **Tested** - [x] Windows 10 64bit Desktop (working) - [ ] Linux Ubuntu (test outstanding) - [ ] MacOS (I need help here - I don't have a Mac here) - [x] Dev mobile (working) - [x] WebApp (working) - [x] Emojis from https://markdown-it.github.io/ rendering (except shortcodes) **Notes** - Emoticons like :-) are not supported. I'll check if [remark-emoticon](https://github.com/zestedesavoir/zmarkdown/tree/master/packages/remark-emoticons) could be used. OK, I've checked this and remark-emoticon is not what I want to use - adding own images is too complicated. [retext-emoji](https://github.com/retextjs/retext-emoji) is better than remark-emoji and also supporting short-codes like :-) (see [demo](https://retextjs.github.io/retext-emoji/)). But I couldn't get remark2retext to work. I think I'll write a remark-plugin that is using [emoticon](https://www.npmjs.com/package/emoticon) for shortcode handling. Or am I missing something? - Emoticons will be supported with an update of remark-emoji. If the following [PR](https://github.com/rhysd/remark-emoji/pull/11) is merged. <!-- Issuehunt content --> --- <details> <summary> <b>IssueHunt Summary</b> </summary> ### Referenced issues This pull request has been submitted to: - [#245: Emoji support](https://issuehunt.io/repos/74213528/issues/245) --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members) </details> <!-- /Issuehunt content--> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:22:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#735
No description provided.