starred/BoostNote-App

Fork 0

mirror of https://github.com/BoostIO/BoostNote-App.git synced 2026-04-26 21:05:55 +03:00

[PR #290] [MERGED] 【Suggestion】Show restore menu when select trashed note #709

New issue

Closed

opened 2026-03-03 00:22:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:22:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/290
Author: @funzin
Created: 1/13/2020
Status: ✅ Merged
Merged: 1/14/2020
Merged by: @Rokt33r

Base: master ← Head: show-restore-menu

📝 Commits (4)

9e0c7a1 Create note.restore
4de479c Show restore menu when select trashed note
6f2ee09 Refactor menuItems
aa5c6da Update korean locale

📊 Changes

7 files changed (+89 additions, -47 deletions)

View changed files

📝 src/components/NotePage/NoteList/NoteItem.tsx (+83 -47)
📝 src/lib/i18n/enUS.ts (+1 -0)
📝 src/lib/i18n/esEs.ts (+1 -0)
📝 src/lib/i18n/ja.ts (+1 -0)
📝 src/lib/i18n/ko.ts (+1 -0)
📝 src/lib/i18n/ptBR.ts (+1 -0)
📝 src/lib/i18n/zhCN.ts (+1 -0)

📄 Description

Problem

Regardless of whether it has been deleted, the following menu is displayed when select note item.

- Duplicate
- Delete
- Bookmark | Remove bookmark

But I think Duplicate and Bookmark | Remove bookmark menu should not be shown when select trashed note.

Suggestion

When select trashed note, the following menu is desirable

- Delete
- Restore

Restore behaves the same as tapping untrashed icon

Change

Add note.restore( some language I didn't understand remains Restore)
Show restore and delete menu when note.trashed is true(not show duplicate and bookmark menu)

GIF

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/290 **Author:** [@funzin](https://github.com/funzin) **Created:** 1/13/2020 **Status:** ✅ Merged **Merged:** 1/14/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `show-restore-menu` --- ### 📝 Commits (4) - [`9e0c7a1`](https://github.com/BoostIO/BoostNote-App/commit/9e0c7a13278e0f90eb79a4eaa71f4b1185d8cbba) Create note.restore - [`4de479c`](https://github.com/BoostIO/BoostNote-App/commit/4de479c19105b0593602460acc88c4cfd8811d3b) Show restore menu when select trashed note - [`6f2ee09`](https://github.com/BoostIO/BoostNote-App/commit/6f2ee09bd9beebeaa4021ef315e6a4cc00458cfd) Refactor menuItems - [`aa5c6da`](https://github.com/BoostIO/BoostNote-App/commit/aa5c6da6d771218ad552fcb7906c59ae816072f4) Update korean locale ### 📊 Changes **7 files changed** (+89 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `src/components/NotePage/NoteList/NoteItem.tsx` (+83 -47) 📝 `src/lib/i18n/enUS.ts` (+1 -0) 📝 `src/lib/i18n/esEs.ts` (+1 -0) 📝 `src/lib/i18n/ja.ts` (+1 -0) 📝 `src/lib/i18n/ko.ts` (+1 -0) 📝 `src/lib/i18n/ptBR.ts` (+1 -0) 📝 `src/lib/i18n/zhCN.ts` (+1 -0) </details> ### 📄 Description ## Problem Regardless of whether it has been deleted, the following menu is displayed when select note item. ``` - Duplicate - Delete - Bookmark | Remove bookmark ``` But I think `Duplicate` and `Bookmark | Remove bookmark` menu should not be shown when select trashed note. ## Suggestion When select trashed note, the following menu is desirable ``` - Delete - Restore ``` `Restore` behaves the same as tapping untrashed icon ## Change - Add `note.restore`( some language I didn't understand remains `Restore`) - Show restore and delete menu when `note.trashed` is true(not show duplicate and bookmark menu) ## GIF ![demo](https://user-images.githubusercontent.com/12893657/72262305-03630900-365a-11ea-8064-1e82f7ba73c4.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:22:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:23:31 +03:00

[PR #709] [MERGED] Overhaul editor UI #858

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#709

No description provided.

Rows
Columns