[PR #280] [MERGED] Show messageBox when delete trashedNote #704

Closed
opened 2026-03-03 00:22:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/280
Author: @funzin
Created: 1/10/2020
Status: Merged
Merged: 1/10/2020
Merged by: @Rokt33r

Base: masterHead: show-dialog-when-delete-trashed-note


📝 Commits (1)

  • 9fafce6 Show messageBox when delete trashedNote

📊 Changes

1 file changed (+21 additions, -3 deletions)

View changed files

📝 src/components/NotePage/NoteList/NoteItem.tsx (+21 -3)

📄 Description

Problem

I tried following steps with BoostNote App.

  1. Select Trashed Tab
  2. Select a Trashed Note and then right click(Open menu)
  3. Select Delete button

but I didn't see any reaction from BoosNote😞

Changes

Show messageBox when delete trashedNote🗑(like select trash icon)
If you select Delete a Note, the note is purged.

CurrentNote is not affect by my implementation.

GIF

demo


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/280 **Author:** [@funzin](https://github.com/funzin) **Created:** 1/10/2020 **Status:** ✅ Merged **Merged:** 1/10/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `show-dialog-when-delete-trashed-note` --- ### 📝 Commits (1) - [`9fafce6`](https://github.com/BoostIO/BoostNote-App/commit/9fafce6a1855a9bd46505af6984d8c50f8682aef) Show messageBox when delete trashedNote ### 📊 Changes **1 file changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/components/NotePage/NoteList/NoteItem.tsx` (+21 -3) </details> ### 📄 Description ## Problem I tried following steps with BoostNote App. 1. Select Trashed Tab 2. Select a Trashed Note and then right click(Open menu) 3. Select Delete button but I didn't see any reaction from BoosNote😞 ## Changes Show messageBox when delete trashedNote🗑(like select trash icon) If you select `Delete a Note`, the note is purged. CurrentNote is not affect by my implementation. ## GIF ![demo](https://user-images.githubusercontent.com/12893657/72166927-80e60980-340d-11ea-9730-42b4b4a56690.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:22:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#704
No description provided.