[PR #251] [MERGED] Add solarized dark to editor themes #690

Closed
opened 2026-03-03 00:22:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/251
Author: @georgeherby
Created: 1/3/2020
Status: Merged
Merged: 1/6/2020
Merged by: @Rokt33r

Base: masterHead: patch-1


📝 Commits (6)

  • 5611af2 Add solarized dark to editor themes
  • b8b1dff Add in import
  • 651d2fa Revert "Add in import"
  • b3c5aa2 Fix issues thanks to the help from Rokt33r
  • 5e4c7dd Remove the console.log
  • b73879f Use kebab case for theme

📊 Changes

4 files changed (+19 additions, -8 deletions)

View changed files

📝 src/components/CodeMirrorStyle.tsx (+3 -0)
📝 src/components/atoms/CodeEditor.tsx (+3 -3)
📝 src/components/atoms/MarkdownPreviewer.tsx (+6 -5)
📝 src/lib/CodeMirror.ts (+7 -0)

📄 Description

This is not 100% finished as I have run into an issue.

I have added the line to add solarized dark to the editor themes. This applies fine but not so when i add it to the code blocks. See image.

image

I am happy to continue the work but would appreciate a pointer to help find out what is up.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/251 **Author:** [@georgeherby](https://github.com/georgeherby) **Created:** 1/3/2020 **Status:** ✅ Merged **Merged:** 1/6/2020 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (6) - [`5611af2`](https://github.com/BoostIO/BoostNote-App/commit/5611af2d76186144e0191e7f43a2044e9d4c4b59) Add solarized dark to editor themes - [`b8b1dff`](https://github.com/BoostIO/BoostNote-App/commit/b8b1dffbedd2f0193b7469b0e44f1cbe35f371e1) Add in import - [`651d2fa`](https://github.com/BoostIO/BoostNote-App/commit/651d2fa6ae62992afc99c70118bb34a7ec8c8d7b) Revert "Add in import" - [`b3c5aa2`](https://github.com/BoostIO/BoostNote-App/commit/b3c5aa2ce60be429188a9940853d0922cdc04e9c) Fix issues thanks to the help from Rokt33r - [`5e4c7dd`](https://github.com/BoostIO/BoostNote-App/commit/5e4c7dd358be00802b28df87af947ad120f2a155) Remove the console.log - [`b73879f`](https://github.com/BoostIO/BoostNote-App/commit/b73879f6a52b745f934059efc02f2867d9ec3179) Use kebab case for theme ### 📊 Changes **4 files changed** (+19 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/components/CodeMirrorStyle.tsx` (+3 -0) 📝 `src/components/atoms/CodeEditor.tsx` (+3 -3) 📝 `src/components/atoms/MarkdownPreviewer.tsx` (+6 -5) 📝 `src/lib/CodeMirror.ts` (+7 -0) </details> ### 📄 Description This is not 100% finished as I have run into an issue. I have added the line to add solarized dark to the editor themes. This applies fine but not so when i add it to the code blocks. See image. ![image](https://user-images.githubusercontent.com/21989833/71747103-b10a3700-2e66-11ea-99a6-029dfc38e0b2.png) I am happy to continue the work but would appreciate a pointer to help find out what is up. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:22:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#690
No description provided.