mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-26 21:05:55 +03:00
[PR #251] [MERGED] Add solarized dark to editor themes #690
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#690
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/251
Author: @georgeherby
Created: 1/3/2020
Status: ✅ Merged
Merged: 1/6/2020
Merged by: @Rokt33r
Base:
master← Head:patch-1📝 Commits (6)
5611af2Add solarized dark to editor themesb8b1dffAdd in import651d2faRevert "Add in import"b3c5aa2Fix issues thanks to the help from Rokt33r5e4c7ddRemove the console.logb73879fUse kebab case for theme📊 Changes
4 files changed (+19 additions, -8 deletions)
View changed files
📝
src/components/CodeMirrorStyle.tsx(+3 -0)📝
src/components/atoms/CodeEditor.tsx(+3 -3)📝
src/components/atoms/MarkdownPreviewer.tsx(+6 -5)📝
src/lib/CodeMirror.ts(+7 -0)📄 Description
This is not 100% finished as I have run into an issue.
I have added the line to add solarized dark to the editor themes. This applies fine but not so when i add it to the code blocks. See image.
I am happy to continue the work but would appreciate a pointer to help find out what is up.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.