mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-26 21:05:55 +03:00
[PR #169] [MERGED] Analytics #632
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#632
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/169
Author: @ButteryCrumpet
Created: 12/18/2019
Status: ✅ Merged
Merged: 12/18/2019
Merged by: @ButteryCrumpet
Base:
master← Head:analytics📝 Commits (7)
3439fb7added analytics wrapper for dbStoreee54e44wrapped dbstore in analytics wrapper962e27eadded preference analytics0f53c92moved preferences analytics to top level4ea2b0bmoved configuration into hook to stop errors on testd557fcbmoved reporting to component6cec74fremove console.log and fix equality bug📊 Changes
4 files changed (+96 additions, -15 deletions)
View changed files
📝
src/components/PreferencesModal/EditorTab.tsx(+4 -1)📝
src/components/PreferencesModal/GeneralTab.tsx(+4 -1)📝
src/lib/analytics.ts(+84 -12)📝
src/lib/db/store.ts(+4 -1)📄 Description
useAnalyticsusesusePreferencesso similar wrapper approach would cause circular dependencies.useUpdateEffecthook to only run on updates.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.