[PR #169] [MERGED] Analytics #632

Closed
opened 2026-03-03 00:22:29 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/169
Author: @ButteryCrumpet
Created: 12/18/2019
Status: Merged
Merged: 12/18/2019
Merged by: @ButteryCrumpet

Base: masterHead: analytics


📝 Commits (7)

  • 3439fb7 added analytics wrapper for dbStore
  • ee54e44 wrapped dbstore in analytics wrapper
  • 962e27e added preference analytics
  • 0f53c92 moved preferences analytics to top level
  • 4ea2b0b moved configuration into hook to stop errors on test
  • d557fcb moved reporting to component
  • 6cec74f remove console.log and fix equality bug

📊 Changes

4 files changed (+96 additions, -15 deletions)

View changed files

📝 src/components/PreferencesModal/EditorTab.tsx (+4 -1)
📝 src/components/PreferencesModal/GeneralTab.tsx (+4 -1)
📝 src/lib/analytics.ts (+84 -12)
📝 src/lib/db/store.ts (+4 -1)

📄 Description

  • analytics involved in db interaction done in a wrapper around the hook
  • preferences analytics done in top level component as useAnalytics uses usePreferences so similar wrapper approach would cause circular dependencies.
  • top level component analytics uses useUpdateEffect hook to only run on updates.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/169 **Author:** [@ButteryCrumpet](https://github.com/ButteryCrumpet) **Created:** 12/18/2019 **Status:** ✅ Merged **Merged:** 12/18/2019 **Merged by:** [@ButteryCrumpet](https://github.com/ButteryCrumpet) **Base:** `master` ← **Head:** `analytics` --- ### 📝 Commits (7) - [`3439fb7`](https://github.com/BoostIO/BoostNote-App/commit/3439fb747af7f9203f3347166a4d3f16feb9a4bb) added analytics wrapper for dbStore - [`ee54e44`](https://github.com/BoostIO/BoostNote-App/commit/ee54e44f8acf393aff5fcd371fe7f77bca50eec4) wrapped dbstore in analytics wrapper - [`962e27e`](https://github.com/BoostIO/BoostNote-App/commit/962e27ecda64734c7df87add1edffdc73ef50ba0) added preference analytics - [`0f53c92`](https://github.com/BoostIO/BoostNote-App/commit/0f53c925ac0323d72c0f7175f9dac0d0f4806e9b) moved preferences analytics to top level - [`4ea2b0b`](https://github.com/BoostIO/BoostNote-App/commit/4ea2b0b3b2e0b1779f43bede68e2d641338e9ba6) moved configuration into hook to stop errors on test - [`d557fcb`](https://github.com/BoostIO/BoostNote-App/commit/d557fcb4539d9b6cf21102054d9b7d07e932d788) moved reporting to component - [`6cec74f`](https://github.com/BoostIO/BoostNote-App/commit/6cec74fcb52df93a635d89e422720cacd71321d7) remove console.log and fix equality bug ### 📊 Changes **4 files changed** (+96 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/components/PreferencesModal/EditorTab.tsx` (+4 -1) 📝 `src/components/PreferencesModal/GeneralTab.tsx` (+4 -1) 📝 `src/lib/analytics.ts` (+84 -12) 📝 `src/lib/db/store.ts` (+4 -1) </details> ### 📄 Description - analytics involved in db interaction done in a wrapper around the hook - preferences analytics done in top level component as `useAnalytics` uses `usePreferences` so similar wrapper approach would cause circular dependencies. - top level component analytics uses `useUpdateEffect` hook to only run on updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:22:29 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#632
No description provided.