[PR #82] [MERGED] Untrash Note #545

New issue

Closed

opened 2026-03-03 00:22:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:22:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/82
Author: @Davy-c
Created: 11/12/2019
Status: ✅ Merged
Merged: 11/12/2019
Merged by: @Rokt33r

Base: master ← Head: fix/untrash-note

📝 Commits (1)

dfdb325 untrash note store and db

📊 Changes

3 files changed (+152 additions, -1 deletions)

View changed files

📝 src/lib/db/NoteDb.ts (+6 -0)
📝 src/lib/db/store.spec.ts (+80 -1)
📝 src/lib/db/store.ts (+66 -0)

📄 Description

Untrash note db upsert for tags
Update tagMap, foldermap, noteMap onuntrashNote hook.

However:

We do not really delete tags for now, so the tag upsert may be unnecessary
We do not currently modify tagMap on the trashNote hook ( handled by the filter on trashed state of the note ), so the tagMap modification may be unnecessary.

Also, trashed notes are still accessible by their app/storages/{storage}/tags/{tag}/{noteId} scheme, is it intended or not?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/82 **Author:** [@Davy-c](https://github.com/Davy-c) **Created:** 11/12/2019 **Status:** ✅ Merged **Merged:** 11/12/2019 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `fix/untrash-note` --- ### 📝 Commits (1) - [`dfdb325`](https://github.com/BoostIO/BoostNote-App/commit/dfdb3252a149da510eb2b52c1ed4e7576b56fa4c) untrash note store and db ### 📊 Changes **3 files changed** (+152 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/db/NoteDb.ts` (+6 -0) 📝 `src/lib/db/store.spec.ts` (+80 -1) 📝 `src/lib/db/store.ts` (+66 -0) </details> ### 📄 Description - Untrash note db upsert for tags - Update `tagMap`, `foldermap`, `noteMap` on`untrashNote` hook. However: - We do not really delete tags for now, so the tag `upsert` may be unnecessary - We do not currently modify `tagMap` on the `trashNote` hook ( handled by the filter on trashed state of the note ), so the tagMap modification may be unnecessary. Also, trashed notes are still accessible by their `app/storages/{storage}/tags/{tag}/{noteId}` scheme, is it intended or not? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:22:05 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:23:14 +03:00

[PR #545] [MERGED] Bump lodash from 4.17.15 to 4.17.19 #794

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#545

No description provided.

Rows
Columns