mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-27 05:15:56 +03:00
[GH-ISSUE #1212] Collapsing left panel: jumping icon and shortcut not working #482
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#482
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @WeberAlex on GitHub (Sep 21, 2021).
Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/1212
Environment
Boost Note Web App 1.50.4
Windows 10 / Chrome
Chrome OS
That's a follow up of #1178. First off, 1.50.4 #1209 is great release 👍 and a big thank you to @Komediruzecki for the continual support.
Issues
Jumping icon
When the mouse pointer is positioned over the icon with the arrow, the icon jumps. I can reproduce it 100% of the time on Windows/Chrome and Chrome OS. Not too surprisingly since this is the same browser.
https://user-images.githubusercontent.com/28292190/134092771-45e29023-a9d0-48d6-ad75-c638e2977b9f.mp4
Shortcut not working
The shortcut
Ctrl + Shift + 0is not working. I have tried with different key combinationFNAltnot to avail.The shortcut
Ctrl + ,to edit the custom CSS of the preview does work!My keyboard is a Japanese logicool K240
@Komediruzecki commented on GitHub (Sep 21, 2021):
Hi, WeberAlex,
I can reproduce the jumping icon issue as well, will be fixed soon.
The shortcut is working for me, but you need to be careful what key combination triggers which key.
For example
Ctrl+Shift+0won't actually trigger that sequence on some keyboards, butCtrl+Shift+numpad0might.Can you check here: https://keycode.info/
if the keypress you are pressing actually triggers keycode for 0, having a shift key in combination could trigger a second set of keys on regular numbers.
And also try shortcuts with Numpad zero. I know some keyboards don't have Numpad keys it, but typically there is an emulation for it (i.e. to bind it somehow)
@Rokt33r commented on GitHub (Sep 22, 2021):
@WeberAlex Seems like we should change the default key binding for Windows. Do you have any preferences?
@WeberAlex commented on GitHub (Sep 22, 2021):
@Rokt33r
Ctrl + Shift + X. It is not already attributed to Chrome, and theXkey does not change regardless of the keyboard layout (fr, ge, us, etc.)@Komediruzecki commented on GitHub (Sep 22, 2021):
I would suggest
Alt+1or similar, it is versatile enough and it's used by IntelliJ IDEs as the default one. Any combination using Control and Shift might be problematic, especially when used with numbers.We can customize it later when we introduce a keymap for it.
@WeberAlex commented on GitHub (Sep 23, 2021):
That's good with me.
@WeberAlex commented on GitHub (Sep 26, 2021):
Alt + 1calls the files folder in Chrome OS,Alt + 2,Alt + 3andAlt + 4call other functions. Please, disregard my previous comment,Alt + 1would not be a good idea. I use an Asus Flip C302.Alt + 5 & 6are available on this model, but I wonder isCtrl + Shift + Z or Xis not a safer bet?@Komediruzecki commented on GitHub (Sep 26, 2021):
It's hard to find something that is not used by some OS,
Alt+1is suitable for the desktop app but not for a web app, since in general browsers bind it to change of tabs with numbers (Chrome, Firefox,Alt+1first tab,Alt+2second, etc.).That's why the best is to have a customizable keymap so users can set it to an appropriate shortcut for themselves.
@WeberAlex commented on GitHub (Sep 29, 2021):
How about modifying the shortcut
Ctrl + Shift + 0at first, until releasing the customizable keymap feature?I can give a list of shortcuts on Windows 10/Chrome that are available.