mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-27 05:15:56 +03:00
[GH-ISSUE #875] PDF export doesn't contain image #427
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#427
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @baermathias on GitHub (Mar 18, 2021).
Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/875
Current behavior
Inside markdown the Image contains an absolute path and it is also displayed in the preview mode:
But inside the exported PDF it looks like this:
Expected behavior
Display the image correctly in the PDF file
Environment
Desktop/Web
@Komediruzecki commented on GitHub (Mar 18, 2021):
Hi, baermathias
I don't think this is the intended way to add attachments to a note. You should instead drag-drop or paste the attachment into boost note so that it saves it into its local storage (ie adds it to the database, and loads it correctly from that place), this way the image will be attached and correctly printed to PDF.
The absolute path scheme works for HTML export since src will be directly added and HTML will pick up the image by absolute location.
From a security standpoint, I don't know how smart is it to go digging for the absolute path image on disk and trying to read/load it to prepare it for PDF export.
As a workaround, you can export it to HTML and from there export to PDF, this should give you the desired result.
If we want to go digging to find the image, we could make this issue a feature request, what do you think @Rokt33r ?
General improvements for PDF and HTML exports, consistency, and fixes will be added to this PR: #761, so you can watch it and once it's released it will include all the bugfixes and approved-feature-requests.
@Rokt33r commented on GitHub (Mar 20, 2021):
I feel quite the same. And I would actually like to ban all references with an absolute path in note contents.
@Komediruzecki commented on GitHub (May 28, 2021):
I'll close this since for now we are not going to support this, please reopen if this is not resolved.