mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-26 21:05:55 +03:00
[GH-ISSUE #856] Potential Command Execution vulnerabilities introduced by main-preload.js #414
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#414
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xiaofen9 on GitHub (Mar 9, 2021).
Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/856
Originally assigned to: @Rokt33r on GitHub.
Hi,
We found that
static/main-preload.jsintroduces dangerous API openShellExternal for arbitrary access on unsafe renderer process.This may lead to remote command execution.
We suggest that a URL check should be enforced at L15, which enforces an allowlist on trusted URLs.
github.com/BoostIO/BoostNote.next@a467dcb960/static/main-preload.js (L14-L17)@Rokt33r commented on GitHub (Aug 20, 2021):
Thanks for reporting. For now, it is okay since we're using the method with safe URLs only. So it won't cause any problems unless a user executing an arbitrary script from dev tools. But I'll make it safer for the case that someone makes a mistake.
@Komediruzecki This could be problematic for the local app since links in the markdown previewer are using this method without any URL filtering.
@xiaofen9 commented on GitHub (Jun 4, 2022):
Fixed by https://github.com/BoostIO/BoostNote.next-local/pull/39