[GH-ISSUE #389] Option to allow HTML tag rendering #172

Closed
opened 2026-03-03 00:19:01 +03:00 by kerem · 11 comments
Owner

Originally created by @Rokt33r on GitHub (Mar 27, 2020).
Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/389

Currently we're sanitizing every html contents by default. But using some html tags, like <img>, are quite common. So we can provide three option like the old app.

  • Sanitize all
  • Sanitize only dangerous contents(XSS) (default)
  • No sanitize

If you really want this, please click 👍 then we prioritize this issue.

Originally created by @Rokt33r on GitHub (Mar 27, 2020). Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/389 Currently we're sanitizing every html contents by default. But using some html tags, like `<img>`, are quite common. So we can provide three option like the old app. - Sanitize all - Sanitize only dangerous contents(XSS) (default) - No sanitize If you really want this, please click :+1: then we prioritize this issue.
kerem 2026-03-03 00:19:01 +03:00
Author
Owner

@derekantrican commented on GitHub (Mar 27, 2020):

I'd vote for something like "sanitize only dangerous". I think, at a minimum, the basics should be allowed: headings, link, image, bold, italic, underline, etc. They should also be allowed inline (for instance: here is text that is <u>under</u>lined)

<!-- gh-comment-id:605121653 --> @derekantrican commented on GitHub (Mar 27, 2020): I'd vote for something like "sanitize only dangerous". I think, at a minimum, the basics should be allowed: headings, link, image, bold, italic, underline, etc. They should also be allowed inline (for instance: `here is text that is <u>under</u>lined`)
Author
Owner

@Rokt33r commented on GitHub (Mar 27, 2020):

I agree with you. The second option should be default. I'll update the body.

<!-- gh-comment-id:605123235 --> @Rokt33r commented on GitHub (Mar 27, 2020): I agree with you. The second option should be default. I'll update the body.
Author
Owner

@frenchiveruti commented on GitHub (May 3, 2020):

Sanitize only dangerous contents(XSS) (default)
I agree.

<!-- gh-comment-id:623046027 --> @frenchiveruti commented on GitHub (May 3, 2020): Sanitize only dangerous contents(XSS) (default) I agree.
Author
Owner

@arcturus140 commented on GitHub (May 3, 2020):

to me it is mostly important to have my existing notes from the old app being correctly represented.

it's not something I essentially need otherwise. I don't understand why there are 3 options presented to the user. Is there really the need for the user to have control over this?

<!-- gh-comment-id:623184255 --> @arcturus140 commented on GitHub (May 3, 2020): to me it is mostly important to have my existing notes from the old app being correctly represented. it's not something I essentially need otherwise. I don't understand why there are 3 options presented to the user. Is there really the need for the user to have control over this?
Author
Owner

@Rokt33r commented on GitHub (May 4, 2020):

it's not something I essentially need otherwise. I don't understand why there are 3 options presented to the user. Is there really the need for the user to have control over this?

Good point. Now I'm thinking to provide the 2nd option only. Then I guess we could know the demands for the last options.

<!-- gh-comment-id:623316997 --> @Rokt33r commented on GitHub (May 4, 2020): > it's not something I essentially need otherwise. I don't understand why there are 3 options presented to the user. Is there really the need for the user to have control over this? Good point. Now I'm thinking to provide the 2nd option only. Then I guess we could know the demands for the last options.
Author
Owner

@Cryo99 commented on GitHub (Jun 2, 2020):

I agree that we definitely need to be able to enter HTML tags into the Markdown and have them rendered correctly. Indeed, Markdown is predicated on this. Not being able to use tags in the Markdown to manage behaviour that isn't covered by it, such as font colouring, strikeththrough, etc., would be a major limitation.

<!-- gh-comment-id:637780544 --> @Cryo99 commented on GitHub (Jun 2, 2020): I agree that we definitely need to be able to enter HTML tags into the Markdown and have them rendered correctly. Indeed, Markdown is [predicated on this](https://daringfireball.net/projects/markdown/syntax#html). Not being able to use tags in the Markdown to manage behaviour that isn't covered by it, such as font colouring, strikeththrough, etc., would be a major limitation.
Author
Owner

@techbecca commented on GitHub (Jun 28, 2020):

I found this issue by searching for why the folding block syntax isn't working properly. Will this issue solve that?

<!-- gh-comment-id:650719090 --> @techbecca commented on GitHub (Jun 28, 2020): I found this issue by searching for why the folding block syntax isn't working properly. Will this issue solve that?
Author
Owner

@Flexo013 commented on GitHub (Jul 11, 2020):

@techbecca I imagine it will.

<!-- gh-comment-id:657073150 --> @Flexo013 commented on GitHub (Jul 11, 2020): @techbecca I imagine it will.
Author
Owner

@merovingienne commented on GitHub (Sep 28, 2020):

@Rokt33r As per this comment on PR 561, does Boost Note support HTML tables in notes?

I haven't been able to get it to work properly. The editor correctly identifies the syntax and highlights it, but the live preview does not render it. HTML exports also have the same issue.

Platform: macOS 10.15.6 (19G2021)
Boost Note version: 0.9.0

ss_Boost_Note_0 9 0_html_table
<!-- gh-comment-id:699856643 --> @merovingienne commented on GitHub (Sep 28, 2020): @Rokt33r As per [this comment on PR 561](https://github.com/BoostIO/BoostNote.next/pull/561#issuecomment-664714342), does Boost Note support HTML tables in notes? I haven't been able to get it to work properly. The editor correctly identifies the syntax and highlights it, but the live preview does not render it. HTML exports also have the same issue. Platform: macOS 10.15.6 (19G2021) Boost Note version: 0.9.0 <img width="1631" alt="ss_Boost_Note_0 9 0_html_table" src="https://user-images.githubusercontent.com/21020841/94407372-ff97f800-0190-11eb-80f5-e9465d70fd2d.png">
Author
Owner

@Flexo013 commented on GitHub (Sep 28, 2020):

@merovingienne HTML tables are not supported as they can be fully created using the markdown format. If there is a large demand for the feature then it's something we will consider.

(Also feel free to create a new issue with the feature request for HTML table tag support.)

<!-- gh-comment-id:700183109 --> @Flexo013 commented on GitHub (Sep 28, 2020): @merovingienne HTML tables are not supported as they can be fully created using the markdown format. If there is a large demand for the feature then it's something we will consider. (Also feel free to create a new issue with the feature request for HTML table tag support.)
Author
Owner

@merovingienne commented on GitHub (Oct 8, 2020):

@Flexo013 thank you for the response!

My use case is to have a list of items within a table cell. This can be easily achieved with HTML tags in old Boostnote, and I was confused by the comment that all HTML tags allowed on GitHub are supported.

Cool, I'll create a new issue :)

<!-- gh-comment-id:705321202 --> @merovingienne commented on GitHub (Oct 8, 2020): @Flexo013 thank you for the response! My use case is to have a list of items within a table cell. This can be easily achieved with HTML tags in old Boostnote, and I was confused by the comment that all HTML tags allowed on GitHub are supported. Cool, I'll create a new issue :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#172
No description provided.