[GH-ISSUE #369] Can't collapse sidebar #154

Closed
opened 2026-03-03 00:18:51 +03:00 by kerem · 14 comments
Owner

Originally created by @pierremonico on GitHub (Mar 1, 2020).
Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/369

Current behavior

When I hit Cmd + B, the sidebar doesn't hide. I also tried with Ctrl + B just in case.

Expected behavior

The sidebar should collapse.

Steps to reproduce

  1. Open the app
  2. Click on SomeStorageName
  3. Click on All Notes
  4. Hit Cmd + B (nothing happens)
  5. Click inside the editor of a given note
  6. Hit Cmd + B (nothing happens)

Environment

  • Boostnote version: 0.1.4
  • OS version and name: macOS High Sierra, 10.13.6
Originally created by @pierremonico on GitHub (Mar 1, 2020). Original GitHub issue: https://github.com/BoostIO/BoostNote-App/issues/369 # Current behavior When I hit `Cmd + B`, the sidebar doesn't hide. I also tried with `Ctrl + B` just in case. # Expected behavior The sidebar should collapse. # Steps to reproduce 1. Open the app 2. Click on `SomeStorageName` 3. Click on `All Notes` 4. Hit `Cmd + B` (nothing happens) 5. Click inside the editor of a given note 6. Hit `Cmd + B` (nothing happens) # Environment - Boostnote version: 0.1.4 - OS version and name: macOS High Sierra, 10.13.6
kerem 2026-03-03 00:18:51 +03:00
Author
Owner

@Rokt33r commented on GitHub (Mar 3, 2020):

The feature is not implemented yet. Thanks for the reminding. We'll work this soon!

<!-- gh-comment-id:594181579 --> @Rokt33r commented on GitHub (Mar 3, 2020): The feature is not implemented yet. Thanks for the reminding. We'll work this soon!
Author
Owner

@pierremonico commented on GitHub (Mar 4, 2020):

Alright, maybe just remove it from the shortcut list in the meantime then :)

<!-- gh-comment-id:594369285 --> @pierremonico commented on GitHub (Mar 4, 2020): Alright, maybe just remove it from the shortcut list in the meantime then :)
Author
Owner

@Flexo013 commented on GitHub (Mar 4, 2020):

@pierremonico What shortcut list?

<!-- gh-comment-id:594841038 --> @Flexo013 commented on GitHub (Mar 4, 2020): @pierremonico What shortcut list?
Author
Owner

@arcturus140 commented on GitHub (Mar 4, 2020):

@Flexo013 see tutorial notes...

<!-- gh-comment-id:594922431 --> @arcturus140 commented on GitHub (Mar 4, 2020): @Flexo013 see tutorial notes...
Author
Owner

@pierremonico commented on GitHub (Mar 6, 2020):

@Flexo013 see tutorial notes...

That's correct.

<!-- gh-comment-id:595691370 --> @pierremonico commented on GitHub (Mar 6, 2020): > @Flexo013 see tutorial notes... That's correct.
Author
Owner

@Rokt33r commented on GitHub (Mar 6, 2020):

I re-opened this so I can keep tracking this issue.

<!-- gh-comment-id:595882391 --> @Rokt33r commented on GitHub (Mar 6, 2020): I re-opened this so I can keep tracking this issue.
Author
Owner

@JohnPhamous commented on GitHub (Mar 7, 2020):

@Rokt33r, are you working on this? If not mind if I take it up? Also saw #333.

<!-- gh-comment-id:596149192 --> @JohnPhamous commented on GitHub (Mar 7, 2020): @Rokt33r, are you working on this? If not mind if I take it up? Also saw #333.
Author
Owner

@Flexo013 commented on GitHub (Mar 8, 2020):

@JohnPhamous Feel free to take this up!

Note that this one specifically is for hiding the entire sidebar. Check old Boostnote to see the exact behavior.

#333 is for making the sidebar smaller, but still usuable.

<!-- gh-comment-id:596218870 --> @Flexo013 commented on GitHub (Mar 8, 2020): @JohnPhamous Feel free to take this up! Note that this one specifically is for hiding the entire sidebar. Check old Boostnote to see the exact behavior. #333 is for making the sidebar smaller, but still usuable.
Author
Owner

@JohnPhamous commented on GitHub (Mar 8, 2020):

@Flexo013 thanks for clarifying. Are there other docs on how to get started working on the codebase? I tried the instructions under Build in the README but got this error

image

<!-- gh-comment-id:596260134 --> @JohnPhamous commented on GitHub (Mar 8, 2020): @Flexo013 thanks for clarifying. Are there other docs on how to get started working on the codebase? I tried the instructions under Build in the README but got this error ![image](https://user-images.githubusercontent.com/16027268/76172268-33f28b00-6151-11ea-830f-bfb927e574a9.png)
Author
Owner

@ZeroX-DG commented on GitHub (Mar 9, 2020):

@JohnPhamous You can create an empty .env file in the root folder and run

npm run dev
<!-- gh-comment-id:596276349 --> @ZeroX-DG commented on GitHub (Mar 9, 2020): @JohnPhamous You can create an empty `.env` file in the root folder and run ``` npm run dev ```
Author
Owner

@Rokt33r commented on GitHub (Mar 25, 2020):

@pierremonico I think #333 is better. The behavior is almost same but I think showing minimized functional UI is superior. Do you think you need hiding sidebar feature even though we have minimizing sidebar feature? If so, let us know why do you think so!

<!-- gh-comment-id:604022098 --> @Rokt33r commented on GitHub (Mar 25, 2020): @pierremonico I think #333 is better. The behavior is almost same but I think showing minimized functional UI is superior. Do you think you need hiding sidebar feature even though we have minimizing sidebar feature? If so, let us know why do you think so!
Author
Owner

@pierremonico commented on GitHub (Mar 25, 2020):

@Rokt33r thanks for asking. The minimized sidebar is perfect, same behaviour as in VS Code 😅
Essentially I just hide the sidebar all the time so I can write and see the result side by side without any other clutter. TLDR: I personally don't need to completely hide the sidebar; minimizing is enough.

<!-- gh-comment-id:604031442 --> @pierremonico commented on GitHub (Mar 25, 2020): @Rokt33r thanks for asking. The minimized sidebar is perfect, same behaviour as in VS Code 😅 Essentially I just hide the sidebar all the time so I can write and see the result side by side without any other clutter. **TLDR**: I personally don't need to completely hide the sidebar; minimizing is enough.
Author
Owner

@Flexo013 commented on GitHub (Mar 26, 2020):

I agree. I personally also don't need a completely hidden sidebar, but I can imagine that some user would like this option. A sort of focus-mode, if you will.

My suggestion is to prioritize #333, and once that is implemented we can gather interest into a complete hide function with this current thread.

<!-- gh-comment-id:604164790 --> @Flexo013 commented on GitHub (Mar 26, 2020): I agree. I personally also don't need a completely hidden sidebar, but I can imagine that some user would like this option. A sort of focus-mode, if you will. My suggestion is to prioritize #333, and once that is implemented we can gather interest into a complete hide function with this current thread.
Author
Owner

@Rokt33r commented on GitHub (Mar 26, 2020):

Thanks for the quick responses! I'll close this and focus on #333.

<!-- gh-comment-id:604245433 --> @Rokt33r commented on GitHub (Mar 26, 2020): Thanks for the quick responses! I'll close this and focus on #333.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#154
No description provided.