[PR #1620] Fix embed conversion prompt label for GitHub issues vs PRs #1469

New issue

Open

opened 2026-03-03 00:26:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:26:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1620
Author: @nicepopo86-lang
Created: 2/17/2026
Status: 🔄 Open

Base: master ← Head: aria/issue-1149-embed-popup-fix

📝 Commits (1)

f3e0b17 Fix GitHub embed prompt label for issue vs pull request

📊 Changes

5 files changed (+26 additions, -12 deletions)

View changed files

📝 src/cloud/components/DocPreview/DocPreviewRealtime.tsx (+1 -1)
📝 src/cloud/components/Editor/index.tsx (+6 -3)
📝 src/cloud/lib/editor/plugins/pasteFormatPlugin.ts (+8 -3)
📝 src/cloud/lib/hooks/editor/docEditor.ts (+5 -2)
📝 src/mobile/components/pages/DocEditPage.tsx (+6 -3)

📄 Description

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1620 **Author:** [@nicepopo86-lang](https://github.com/nicepopo86-lang) **Created:** 2/17/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `aria/issue-1149-embed-popup-fix` --- ### 📝 Commits (1) - [`f3e0b17`](https://github.com/BoostIO/BoostNote-App/commit/f3e0b17cbb8d2aecbf8496eb8d2c1f49a65b1d71) Fix GitHub embed prompt label for issue vs pull request ### 📊 Changes **5 files changed** (+26 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/components/DocPreview/DocPreviewRealtime.tsx` (+1 -1) 📝 `src/cloud/components/Editor/index.tsx` (+6 -3) 📝 `src/cloud/lib/editor/plugins/pasteFormatPlugin.ts` (+8 -3) 📝 `src/cloud/lib/hooks/editor/docEditor.ts` (+5 -2) 📝 `src/mobile/components/pages/DocEditPage.tsx` (+6 -3) </details> ### 📄 Description ## Summary\nThis fixes the GitHub URL conversion prompt so it reflects the pasted URL type:\n- -> **Embed pull request**\n- -> **Embed issue**\n\nThe previous prompt used a generic action and did not clarify issue vs PR intent. This addresses #1149's request for proper distinction in the embed popup flow.\n\n## Reproduction\n1. Open markdown editor.\n2. Paste a GitHub issue URL ().\n3. Observe conversion popup text.\n\n## Before\n- Prompt action text did not distinguish issue vs PR.\n\n## After\n- Prompt action text is context-aware ( / ).\n\n## Technical changes\n- Extended paste formatter result with optional .\n- Wired through menu callback.\n- Updated cloud editor, doc preview realtime hook path, and mobile doc editor to render the contextual label.\n\n## Validation\n- Static code review of conversion paths in cloud + mobile editor pipelines.\n- Dependency installation for local lint timed out in this environment; code changes are intentionally minimal and type-local.\n --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-03-03 00:26:26 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#1469

No description provided.

Rows
Columns