[PR #1560] [MERGED] remove page{Doc|Folder|Workspace} if exists in pageProps merge data #1445

New issue

Closed

opened 2026-03-03 00:26:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:26:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1560
Author: @ButteryCrumpet
Created: 5/16/2022
Status: ✅ Merged
Merged: 5/16/2022
Merged by: @ButteryCrumpet

Base: master ← Head: bug/only-default-workspace-breadcrumb

📝 Commits (1)

53a0442 remove page{Doc|Folder|Workspace} if exists in pageProps merge data

📊 Changes

1 file changed (+21 additions, -3 deletions)

View changed files

📝 src/cloud/lib/stores/pageStore/store.tsx (+21 -3)

📄 Description

Issue

Breadcrumbs would show only last visited workspace on every page.

Cause

Merging new pageProps into existing would not remove old page{Doc|Folder|Workspace} if it was a page transition.

Fix

Remove old page{Doc|Folder|Workspace} if page{Doc|Folder|Workspace} exists in new merge data

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1560 **Author:** [@ButteryCrumpet](https://github.com/ButteryCrumpet) **Created:** 5/16/2022 **Status:** ✅ Merged **Merged:** 5/16/2022 **Merged by:** [@ButteryCrumpet](https://github.com/ButteryCrumpet) **Base:** `master` ← **Head:** `bug/only-default-workspace-breadcrumb` --- ### 📝 Commits (1) - [`53a0442`](https://github.com/BoostIO/BoostNote-App/commit/53a044267250223e1dc29131aea3dc8ccfa9e338) remove page{Doc|Folder|Workspace} if exists in pageProps merge data ### 📊 Changes **1 file changed** (+21 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/lib/stores/pageStore/store.tsx` (+21 -3) </details> ### 📄 Description # Issue Breadcrumbs would show only last visited workspace on every page. # Cause Merging new `pageProps` into existing would not remove old `page{Doc|Folder|Workspace}` if it was a page transition. # Fix Remove old `page{Doc|Folder|Workspace}` if `page{Doc|Folder|Workspace}` exists in new merge data --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:26:20 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#1445

No description provided.

Rows
Columns