[PR #1463] [MERGED] remove loader master comp. #1367

New issue

Closed

opened 2026-03-03 00:25:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:25:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1463
Author: @Davy-c
Created: 1/31/2022
Status: ✅ Merged
Merged: 2/2/2022
Merged by: @Davy-c

Base: master ← Head: refactor/loaders

📝 Commits (5)

8a1dd11 remove loader index
c55d5db fix application page loader props
273743d rename store
32d9605 remove unnecessary tsconfig change
4f25d51 prettify check

📊 Changes

30 files changed (+311 additions, -379 deletions)

View changed files

📝 src/cloud/components/Application.tsx (+2 -2)
📝 src/cloud/components/ApplicationPageLoader.tsx (+4 -6)
📝 src/cloud/components/ApplicationWithoutInfoLoader.tsx (+6 -5)
📝 src/cloud/components/DashboardPage/index.tsx (+2 -2)
📝 src/cloud/components/DocPreview/DocPreviewRealtime.tsx (+2 -2)
📝 src/cloud/components/DocPreview/index.tsx (+2 -2)
📝 src/cloud/components/FolderPage/index.tsx (+2 -1)
📝 src/cloud/components/MarkdownView/index.tsx (+2 -2)
📝 src/cloud/components/WorkspacePage/index.tsx (+2 -1)
📝 src/cloud/components/settings/MembersTab.tsx (+1 -3)
➕ src/cloud/lib/stores/loaders/index.ts (+9 -0)
➕ src/cloud/lib/stores/loaders/store.ts (+30 -0)
➕ src/cloud/lib/stores/loaders/withLoaderProps.tsx (+16 -0)
➖ src/design/components/atoms/loaders/DocEditorLoader.tsx (+0 -26)
➖ src/design/components/atoms/loaders/FolderPageLoader.tsx (+0 -26)
➕ src/design/components/atoms/loaders/LoaderDocEditor.tsx (+26 -0)
➕ src/design/components/atoms/loaders/LoaderFolderPage.tsx (+26 -0)
➕ src/design/components/atoms/loaders/LoaderNavItem.tsx (+42 -0)
➕ src/design/components/atoms/loaders/LoaderSmartView.tsx (+26 -0)
➕ src/design/components/atoms/loaders/LoaderTeamPicker.tsx (+26 -0)

...and 10 more files

📄 Description

Refactor loaders

Remove master loader component
Add helper for common props and theme
Renamed Loaders with shared prefix for easier access

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1463 **Author:** [@Davy-c](https://github.com/Davy-c) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 2/2/2022 **Merged by:** [@Davy-c](https://github.com/Davy-c) **Base:** `master` ← **Head:** `refactor/loaders` --- ### 📝 Commits (5) - [`8a1dd11`](https://github.com/BoostIO/BoostNote-App/commit/8a1dd119d0d9ebec206c8aded1b99e54681d3399) remove loader index - [`c55d5db`](https://github.com/BoostIO/BoostNote-App/commit/c55d5db638659bfc56e7f4c7e50f731626a44c2d) fix application page loader props - [`273743d`](https://github.com/BoostIO/BoostNote-App/commit/273743d6c4bb8b507f2d8751ab070f5e9b8329c2) rename store - [`32d9605`](https://github.com/BoostIO/BoostNote-App/commit/32d96059c57d545088f0d73e7d91dafd277ec99b) remove unnecessary tsconfig change - [`4f25d51`](https://github.com/BoostIO/BoostNote-App/commit/4f25d51537fb521b9aa00e2af2b61ba41ddf960f) prettify check ### 📊 Changes **30 files changed** (+311 additions, -379 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/components/Application.tsx` (+2 -2) 📝 `src/cloud/components/ApplicationPageLoader.tsx` (+4 -6) 📝 `src/cloud/components/ApplicationWithoutInfoLoader.tsx` (+6 -5) 📝 `src/cloud/components/DashboardPage/index.tsx` (+2 -2) 📝 `src/cloud/components/DocPreview/DocPreviewRealtime.tsx` (+2 -2) 📝 `src/cloud/components/DocPreview/index.tsx` (+2 -2) 📝 `src/cloud/components/FolderPage/index.tsx` (+2 -1) 📝 `src/cloud/components/MarkdownView/index.tsx` (+2 -2) 📝 `src/cloud/components/WorkspacePage/index.tsx` (+2 -1) 📝 `src/cloud/components/settings/MembersTab.tsx` (+1 -3) ➕ `src/cloud/lib/stores/loaders/index.ts` (+9 -0) ➕ `src/cloud/lib/stores/loaders/store.ts` (+30 -0) ➕ `src/cloud/lib/stores/loaders/withLoaderProps.tsx` (+16 -0) ➖ `src/design/components/atoms/loaders/DocEditorLoader.tsx` (+0 -26) ➖ `src/design/components/atoms/loaders/FolderPageLoader.tsx` (+0 -26) ➕ `src/design/components/atoms/loaders/LoaderDocEditor.tsx` (+26 -0) ➕ `src/design/components/atoms/loaders/LoaderFolderPage.tsx` (+26 -0) ➕ `src/design/components/atoms/loaders/LoaderNavItem.tsx` (+42 -0) ➕ `src/design/components/atoms/loaders/LoaderSmartView.tsx` (+26 -0) ➕ `src/design/components/atoms/loaders/LoaderTeamPicker.tsx` (+26 -0) _...and 10 more files_ </details> ### 📄 Description Refactor loaders - Remove master loader component - Add helper for common props and theme - Renamed Loaders with shared prefix for easier access --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:25:51 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#1367

No description provided.

Rows
Columns