mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-27 05:15:56 +03:00
[PR #1422] [MERGED] Add query param view for smart view views #1335
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#1335
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/1422
Author: @Komediruzecki
Created: 1/3/2022
Status: ✅ Merged
Merged: 1/18/2022
Merged by: @Davy-c
Base:
feat/default-view-inselector← Head:feature/add-smart-view-query📝 Commits (3)
0257de1Add query param view for smart view views05a1639Add shallow URL replace when user clicks on view9a2571bAdd view query for link copy in desktop app📊 Changes
3 files changed (+40 additions, -6 deletions)
View changed files
📝
src/cloud/components/FolderPage/NewFolderContextMenu.tsx(+10 -2)📝
src/cloud/components/Views/index.tsx(+20 -1)📝
src/cloud/components/WorkspacePage/WorkspaceContextMenu.tsx(+10 -3)📄 Description
Add query param view for smart view views
Tested with invalid queries and valid view IDs, like:
http://localhost:3001/testspace/dashboard?view=20after creating the views with those IDs.Tested with folder/workspace as well:
http://localhost:3001/testspace/Sprint-meeting-fDdf3f8586d2004bba9b1bf5df0b423ce2?view=26Short video showcase:
https://user-images.githubusercontent.com/18196945/148118036-847ae133-18e4-4905-8229-768518615066.mp4
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.