[PR #1190] [MERGED] Fix IME popups occluding the current line #1194

Closed
opened 2026-03-03 00:25:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1190
Author: @Komediruzecki
Created: 9/16/2021
Status: Merged
Merged: 9/18/2021
Merged by: @Rokt33r

Base: masterHead: bugfix/fix-ime-codemirror


📝 Commits (1)

  • 1e4d8cc Fix IME popups occluding the current line

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/cloud/components/Editor/index.tsx (+2 -0)

📄 Description

Fix IME popups occluding the current line

Before fix:
image
image

After fix:
Tested in Chrome WebApp and Electron Desktop App

Showcase:

https://user-images.githubusercontent.com/18196945/133665039-08f0b2cb-3cae-4f32-be19-37047fe7d294.mp4

Didn't test on Windows but the behavior is the same on Ubuntu and Windows, and this fixes Ubuntu behavior.

Fixes: #1189


IssueHunt Summary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1190 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 9/16/2021 **Status:** ✅ Merged **Merged:** 9/18/2021 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `bugfix/fix-ime-codemirror` --- ### 📝 Commits (1) - [`1e4d8cc`](https://github.com/BoostIO/BoostNote-App/commit/1e4d8cc20c1324e1919c40c2145e5b06db61317f) Fix IME popups occluding the current line ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/components/Editor/index.tsx` (+2 -0) </details> ### 📄 Description Fix IME popups occluding the current line Before fix: ![image](https://user-images.githubusercontent.com/18196945/133665366-ddd6ff0a-23b3-464d-9556-4f28f7521d7a.png) ![image](https://user-images.githubusercontent.com/18196945/133665404-a5305b75-b43d-45e3-ad21-bc93873cc445.png) After fix: Tested in Chrome WebApp and Electron Desktop App Showcase: https://user-images.githubusercontent.com/18196945/133665039-08f0b2cb-3cae-4f32-be19-37047fe7d294.mp4 Didn't test on Windows but the behavior is the same on Ubuntu and Windows, and this fixes Ubuntu behavior. Fixes: #1189 <!-- Issuehunt content --> --- <details> <summary> <b>IssueHunt Summary</b> </summary> </details> <!-- /Issuehunt content--> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:25:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#1194
No description provided.