mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-27 05:15:56 +03:00
[PR #1182] [MERGED] Add editor line numbers preference #1191
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#1191
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/1182
Author: @Komediruzecki
Created: 9/13/2021
Status: ✅ Merged
Merged: 9/15/2021
Merged by: @Rokt33r
Base:
master← Head:feature/show-hide-editor-line-numbers📝 Commits (1)
d2b23d4Add editor line numbers preference📊 Changes
10 files changed (+48 additions, -2 deletions)
View changed files
📝
src/cloud/components/Editor/index.tsx(+2 -1)📝
src/cloud/components/settings/UserPreferencesForm.tsx(+37 -0)📝
src/cloud/lib/i18n/enUS.ts(+1 -0)📝
src/cloud/lib/i18n/fr.ts(+1 -0)📝
src/cloud/lib/i18n/ja.ts(+1 -0)📝
src/cloud/lib/i18n/types.ts(+1 -0)📝
src/cloud/lib/i18n/zhCN.ts(+1 -0)📝
src/cloud/lib/stores/settings/store.ts(+1 -0)📝
src/cloud/lib/stores/settings/types.ts(+1 -0)📝
src/mobile/components/pages/DocEditPage.tsx(+2 -1)📄 Description
Update mobile and basic edit page
Update preferences handling
Add show/hide option to PreferencesTab
Tested in desktop app and web app, showcase:
https://user-images.githubusercontent.com/18196945/133117996-d930eaa8-3210-459f-83e3-81a6d7278e84.mp4
Fixes: https://github.com/Boostnote/BoostHub/issues/1360
Relates to: https://github.com/BoostIO/BoostNote-App/discussions/1174
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.