mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-27 05:15:56 +03:00
[PR #1134] [MERGED] Add in page search #1169
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#1169
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/1134
Author: @Komediruzecki
Created: 8/31/2021
Status: ✅ Merged
Merged: 9/8/2021
Merged by: @Rokt33r
Base:
master← Head:feature/add-global-search-dialog📝 Commits (4)
7c3a1bcAdd in page search740d1ccUpdate in page search focus handling1412aacFix web contents found in page eventse8fea59Add callback types for found in page events📊 Changes
7 files changed (+447 additions, -2 deletions)
View changed files
📝
src/cloud/components/Application.tsx(+27 -2)➕
src/cloud/components/molecules/PageSearch/InPageSearchPortal.tsx(+347 -0)📝
src/cloud/lib/shortcuts.ts(+9 -0)📝
src/cloud/lib/stores/electron.ts(+12 -0)📝
src/design/components/atoms/GlobalStyle.tsx(+1 -0)📝
src/lib/electronOnly.ts(+9 -0)📝
static/boosthub-preload.js(+42 -0)📄 Description
Add search portal
Add search components
Add search logic and API call
Implement search UI and styling
Add left/right actions (next/previous) and events
Add hack for hide/show input on search (hide elements)
Showcase:
https://user-images.githubusercontent.com/18196945/131561521-6e48c72c-47f1-4f59-a329-cd118c8c94ee.mp4
Showcase with focus:
Uploading 2021-09-01 20-52-32.mp4…
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.