[PR #1134] [MERGED] Add in page search #1169

Closed
opened 2026-03-03 00:24:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1134
Author: @Komediruzecki
Created: 8/31/2021
Status: Merged
Merged: 9/8/2021
Merged by: @Rokt33r

Base: masterHead: feature/add-global-search-dialog


📝 Commits (4)

  • 7c3a1bc Add in page search
  • 740d1cc Update in page search focus handling
  • 1412aac Fix web contents found in page events
  • e8fea59 Add callback types for found in page events

📊 Changes

7 files changed (+447 additions, -2 deletions)

View changed files

📝 src/cloud/components/Application.tsx (+27 -2)
src/cloud/components/molecules/PageSearch/InPageSearchPortal.tsx (+347 -0)
📝 src/cloud/lib/shortcuts.ts (+9 -0)
📝 src/cloud/lib/stores/electron.ts (+12 -0)
📝 src/design/components/atoms/GlobalStyle.tsx (+1 -0)
📝 src/lib/electronOnly.ts (+9 -0)
📝 static/boosthub-preload.js (+42 -0)

📄 Description

Add search portal
Add search components
Add search logic and API call

Implement search UI and styling

Add left/right actions (next/previous) and events
Add hack for hide/show input on search (hide elements)

Showcase:

https://user-images.githubusercontent.com/18196945/131561521-6e48c72c-47f1-4f59-a329-cd118c8c94ee.mp4

Showcase with focus:

Uploading 2021-09-01 20-52-32.mp4…


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1134 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 8/31/2021 **Status:** ✅ Merged **Merged:** 9/8/2021 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `feature/add-global-search-dialog` --- ### 📝 Commits (4) - [`7c3a1bc`](https://github.com/BoostIO/BoostNote-App/commit/7c3a1bc527bb44ce1f636d310dd6ddffe62eb7a0) Add in page search - [`740d1cc`](https://github.com/BoostIO/BoostNote-App/commit/740d1cc3f85f84922f523b6b07f32fb83d0b46c8) Update in page search focus handling - [`1412aac`](https://github.com/BoostIO/BoostNote-App/commit/1412aac2f1ee4ed8c0de3f985e1547e655b4862b) Fix web contents found in page events - [`e8fea59`](https://github.com/BoostIO/BoostNote-App/commit/e8fea5991f0b02d8dc9e44a302da4d4a777869b8) Add callback types for found in page events ### 📊 Changes **7 files changed** (+447 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/components/Application.tsx` (+27 -2) ➕ `src/cloud/components/molecules/PageSearch/InPageSearchPortal.tsx` (+347 -0) 📝 `src/cloud/lib/shortcuts.ts` (+9 -0) 📝 `src/cloud/lib/stores/electron.ts` (+12 -0) 📝 `src/design/components/atoms/GlobalStyle.tsx` (+1 -0) 📝 `src/lib/electronOnly.ts` (+9 -0) 📝 `static/boosthub-preload.js` (+42 -0) </details> ### 📄 Description Add search portal Add search components Add search logic and API call Implement search UI and styling Add left/right actions (next/previous) and events Add hack for hide/show input on search (hide elements) Showcase: https://user-images.githubusercontent.com/18196945/131561521-6e48c72c-47f1-4f59-a329-cd118c8c94ee.mp4 Showcase with focus: Uploading 2021-09-01 20-52-32.mp4… --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:24:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/BoostNote-App#1169
No description provided.