starred/BoostNote-App

Fork 0

mirror of https://github.com/BoostIO/BoostNote-App.git synced 2026-04-27 05:15:56 +03:00

[PR #1089] [MERGED] Refactor Drag and Drop and implement sidenav and folder view dragging #1142

New issue

Closed

opened 2026-03-03 00:24:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:24:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1089
Author: @Komediruzecki
Created: 8/12/2021
Status: ✅ Merged
Merged: 8/19/2021
Merged by: @Rokt33r

Base: master ← Head: feature/dnd-inside-folder-view

📝 Commits (1)

155a8a0 Add dnd inside folder view and across sidenav and folder view

📊 Changes

10 files changed (+404 additions, -103 deletions)

View changed files

📝 src/cloud/components/molecules/ContentManager/Rows/ContentManagerDocRow.tsx (+9 -0)
📝 src/cloud/components/molecules/ContentManager/Rows/ContentManagerFolderRow.tsx (+10 -0)
📝 src/cloud/components/molecules/ContentManager/Rows/ContentManagerRow.tsx (+56 -3)
📝 src/cloud/components/molecules/ContentManager/index.tsx (+65 -3)
📝 src/cloud/interfaces/resources.ts (+26 -4)
📝 src/cloud/lib/hooks/sidebar/useCloudDnd.ts (+76 -31)
📝 src/cloud/lib/hooks/sidebar/useCloudSidebarTree.tsx (+60 -40)
📝 src/cloud/lib/hooks/useCloudApi.ts (+12 -2)
📝 src/cloud/lib/utils/patterns.ts (+75 -5)
📝 src/shared/components/organisms/Sidebar/molecules/SidebarTree.tsx (+15 -15)

📄 Description

Add dnd inside folder view and across sidenav and folder view

Add callbacks for dnd functions
Update lower level components to use dnd functions

Add initial dnd refactor

Replace dragged resource with resource saving in transfer data
Change APIs across codebase (dragStart, dragEnd, dropOn)
Add text/plain data transfer to folder and doc dragg save events

Drag and drop showcase:

https://user-images.githubusercontent.com/18196945/129209367-f6e27f3d-3cfe-44d0-9dd1-26b09e8ef716.mp4

Tested in desktop app

Test dropping a folder inside another folder (all views, only folders view)
Test dropping a note inside another folder
Test dropping a note/folder from folder view to sidebar (works)

Current bug (I think already present before)

Dropping in workspace/root folder gives already present but it is not
Dropping in lower level folders works

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1089 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 8/12/2021 **Status:** ✅ Merged **Merged:** 8/19/2021 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `feature/dnd-inside-folder-view` --- ### 📝 Commits (1) - [`155a8a0`](https://github.com/BoostIO/BoostNote-App/commit/155a8a0bcc0a1ab2387561f232467f4d239cfdc8) Add dnd inside folder view and across sidenav and folder view ### 📊 Changes **10 files changed** (+404 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/components/molecules/ContentManager/Rows/ContentManagerDocRow.tsx` (+9 -0) 📝 `src/cloud/components/molecules/ContentManager/Rows/ContentManagerFolderRow.tsx` (+10 -0) 📝 `src/cloud/components/molecules/ContentManager/Rows/ContentManagerRow.tsx` (+56 -3) 📝 `src/cloud/components/molecules/ContentManager/index.tsx` (+65 -3) 📝 `src/cloud/interfaces/resources.ts` (+26 -4) 📝 `src/cloud/lib/hooks/sidebar/useCloudDnd.ts` (+76 -31) 📝 `src/cloud/lib/hooks/sidebar/useCloudSidebarTree.tsx` (+60 -40) 📝 `src/cloud/lib/hooks/useCloudApi.ts` (+12 -2) 📝 `src/cloud/lib/utils/patterns.ts` (+75 -5) 📝 `src/shared/components/organisms/Sidebar/molecules/SidebarTree.tsx` (+15 -15) </details> ### 📄 Description Add dnd inside folder view and across sidenav and folder view Add callbacks for dnd functions Update lower level components to use dnd functions Add initial dnd refactor Replace dragged resource with resource saving in transfer data Change APIs across codebase (dragStart, dragEnd, dropOn) Add text/plain data transfer to folder and doc dragg save events Drag and drop showcase: https://user-images.githubusercontent.com/18196945/129209367-f6e27f3d-3cfe-44d0-9dd1-26b09e8ef716.mp4 Tested in desktop app - Test dropping a folder inside another folder (all views, only folders view) - Test dropping a note inside another folder - Test dropping a note/folder from folder view to sidebar (works) Current bug (I think already present before) - Dropping in workspace/root folder gives already present but it is not - Dropping in lower level folders works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:24:49 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:24:57 +03:00

[PR #1142] [MERGED] Blocks UI/UX #1172

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#1142

No description provided.

Rows
Columns