[PR #1090] [MERGED] Fix wrong offset calculation for links #1141

New issue

Closed

opened 2026-03-03 00:24:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:24:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1090
Author: @Komediruzecki
Created: 8/12/2021
Status: ✅ Merged
Merged: 8/13/2021
Merged by: @Rokt33r

Base: master ← Head: bugfix/fix-md-link-comment-not-calculating-offset-correctly

📝 Commits (2)

e8d1174 Fix wrong offset calculation for links
bdf190d Replace == with ===

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/cloud/components/atoms/MarkdownView/index.tsx (+5 -1)

📄 Description

The offset should be calculate from parents parent node not parent node of text segment selection

Tested in desktop app and webapp:

Add comment on plain text
Add comment on link
Add comment on header link

Showcase test:

https://user-images.githubusercontent.com/18196945/129226243-c58e1ed3-4008-4399-a644-d25a3ef09a53.mp4

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1090 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 8/12/2021 **Status:** ✅ Merged **Merged:** 8/13/2021 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `bugfix/fix-md-link-comment-not-calculating-offset-correctly` --- ### 📝 Commits (2) - [`e8d1174`](https://github.com/BoostIO/BoostNote-App/commit/e8d117472c58652e67764d571b46c81dc7400b1b) Fix wrong offset calculation for links - [`bdf190d`](https://github.com/BoostIO/BoostNote-App/commit/bdf190dffe203eaf02ab9884323cca67285d35fb) Replace == with === ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/components/atoms/MarkdownView/index.tsx` (+5 -1) </details> ### 📄 Description The offset should be calculate from parents parent node not parent node of text segment selection Tested in desktop app and webapp: - Add comment on plain text - Add comment on link - Add comment on header link Showcase test: https://user-images.githubusercontent.com/18196945/129226243-c58e1ed3-4008-4399-a644-d25a3ef09a53.mp4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:24:49 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#1141

No description provided.

Rows
Columns