[PR #1088] [MERGED] Implement custom font settings #1139

New issue

Closed

opened 2026-03-03 00:24:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:24:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/BoostIO/BoostNote-App/pull/1088
Author: @Komediruzecki
Created: 8/12/2021
Status: ✅ Merged
Merged: 8/14/2021
Merged by: @Rokt33r

Base: master ← Head: feature/add-customizable-font-preferences

📝 Commits (4)

5d937ea Implement custom font settings
43a1086 Fix ref hooks
1ee7921 Discard unnecessary memo hooks
6188ca6 Fix white out issue

📊 Changes

26 files changed (+164 additions, -36 deletions)

View changed files

📝 src/cloud/components/molecules/Editor/EditorAdmonitionToolDropdown.tsx (+2 -2)
📝 src/cloud/components/molecules/Editor/EditorHeaderToolDropdown.tsx (+2 -2)
📝 src/cloud/components/molecules/Editor/index.tsx (+21 -3)
📝 src/cloud/components/molecules/RelativeDialog/RelativeDialog.tsx (+2 -2)
📝 src/cloud/components/molecules/Timeline/TimelineList.tsx (+2 -2)
📝 src/cloud/components/organisms/EventSource.tsx (+1 -1)
📝 src/cloud/components/organisms/ImportFlow/molecules/ImportFlowDestination.tsx (+2 -2)
📝 src/cloud/components/organisms/Modal/contents/TemplatesModal/index.tsx (+2 -2)
📝 src/cloud/components/organisms/Topbar/Controls/ControlsContextMenu/FolderContextMenu.tsx (+2 -2)
📝 src/cloud/components/organisms/Topbar/Controls/ControlsContextMenu/TagContextMenu.tsx (+2 -2)
📝 src/cloud/components/organisms/settings/SettingsComponent.tsx (+3 -3)
📝 src/cloud/components/organisms/settings/UserPreferencesForm.tsx (+70 -1)
📝 src/cloud/lib/i18n/enUS.ts (+2 -0)
📝 src/cloud/lib/i18n/fr.ts (+2 -0)
📝 src/cloud/lib/i18n/ja.ts (+2 -0)
📝 src/cloud/lib/i18n/types.ts (+2 -0)
📝 src/cloud/lib/i18n/zhCN.ts (+2 -0)
📝 src/cloud/lib/stores/settings/store.ts (+3 -0)
📝 src/cloud/lib/stores/settings/types.ts (+2 -0)
📝 src/components/App.tsx (+3 -0)

...and 6 more files

📄 Description

Add font size and family to Account Preferences
Add translations keys and translations for all supported languages for new Settings
Update mobile and desktop app code mirror editor to respect font size and font families

Tested in desktop app

Changing font works
Changing font family works
Changing languages shows correct preferences descriptions
Changing font family loses focus after update (not sure why it happens here and not in local space)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BoostIO/BoostNote-App/pull/1088 **Author:** [@Komediruzecki](https://github.com/Komediruzecki) **Created:** 8/12/2021 **Status:** ✅ Merged **Merged:** 8/14/2021 **Merged by:** [@Rokt33r](https://github.com/Rokt33r) **Base:** `master` ← **Head:** `feature/add-customizable-font-preferences` --- ### 📝 Commits (4) - [`5d937ea`](https://github.com/BoostIO/BoostNote-App/commit/5d937eaa29c7986a0bd90c6e8543d37a88643883) Implement custom font settings - [`43a1086`](https://github.com/BoostIO/BoostNote-App/commit/43a108637c3a9cbc3bdead7fd9dd3f321e951c3f) Fix ref hooks - [`1ee7921`](https://github.com/BoostIO/BoostNote-App/commit/1ee792139feb7468888eb99cc6219da0bb3c11c1) Discard unnecessary memo hooks - [`6188ca6`](https://github.com/BoostIO/BoostNote-App/commit/6188ca6275c0e794380352ab31eb9e1cd5fd2370) Fix white out issue ### 📊 Changes **26 files changed** (+164 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/cloud/components/molecules/Editor/EditorAdmonitionToolDropdown.tsx` (+2 -2) 📝 `src/cloud/components/molecules/Editor/EditorHeaderToolDropdown.tsx` (+2 -2) 📝 `src/cloud/components/molecules/Editor/index.tsx` (+21 -3) 📝 `src/cloud/components/molecules/RelativeDialog/RelativeDialog.tsx` (+2 -2) 📝 `src/cloud/components/molecules/Timeline/TimelineList.tsx` (+2 -2) 📝 `src/cloud/components/organisms/EventSource.tsx` (+1 -1) 📝 `src/cloud/components/organisms/ImportFlow/molecules/ImportFlowDestination.tsx` (+2 -2) 📝 `src/cloud/components/organisms/Modal/contents/TemplatesModal/index.tsx` (+2 -2) 📝 `src/cloud/components/organisms/Topbar/Controls/ControlsContextMenu/FolderContextMenu.tsx` (+2 -2) 📝 `src/cloud/components/organisms/Topbar/Controls/ControlsContextMenu/TagContextMenu.tsx` (+2 -2) 📝 `src/cloud/components/organisms/settings/SettingsComponent.tsx` (+3 -3) 📝 `src/cloud/components/organisms/settings/UserPreferencesForm.tsx` (+70 -1) 📝 `src/cloud/lib/i18n/enUS.ts` (+2 -0) 📝 `src/cloud/lib/i18n/fr.ts` (+2 -0) 📝 `src/cloud/lib/i18n/ja.ts` (+2 -0) 📝 `src/cloud/lib/i18n/types.ts` (+2 -0) 📝 `src/cloud/lib/i18n/zhCN.ts` (+2 -0) 📝 `src/cloud/lib/stores/settings/store.ts` (+3 -0) 📝 `src/cloud/lib/stores/settings/types.ts` (+2 -0) 📝 `src/components/App.tsx` (+3 -0) _...and 6 more files_ </details> ### 📄 Description Add font size and family to Account Preferences Add translations keys and translations for all supported languages for new Settings Update mobile and desktop app code mirror editor to respect font size and font families Tested in desktop app - Changing font works - Changing font family works - Changing languages shows correct preferences descriptions - Changing font family loses focus after update (not sure why it happens here and not in local space) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 00:24:48 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-03 00:24:57 +03:00

[PR #1139] [MERGED] Feat/blocks v3 #1171

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/BoostNote-App#1139

No description provided.

Rows
Columns