mirror of
https://github.com/BoostIO/BoostNote-App.git
synced 2026-04-27 05:15:56 +03:00
[PR #1081] [CLOSED] Add expandable image in markdown preview #1137
Labels
No labels
android 🤖
assigned to core 🦹
bug 🐛
documentation 📚
documentation 📚
duplicate 🚫
external issue 🔼
external issue 🔼
feature request 🌟
funded on issuehunt 💵
help wanted 🆘
improvement request 🔨
improvement request 🔨
ios 🍎
mobile 📱
needs investigation 🔬
needs more info ℹ️
needs specs 📐
plugin idea 🔌
plugin idea 🔌
poll 🗳️
pull-request
question ❓
rewarded on issuehunt 🎁
security issue 🔑
won’t fix ❌
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/BoostNote-App#1137
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/BoostIO/BoostNote-App/pull/1081
Author: @Komediruzecki
Created: 8/10/2021
Status: ❌ Closed
Base:
master← Head:feature/image-actions-md-preview📝 Commits (3)
ed62d16Add expandable image in markdown preview18d7702Change ExpandableImage div elements to span10605e1Expand modal dialog📊 Changes
5 files changed (+142 additions, -2 deletions)
View changed files
📝
src/cloud/components/atoms/MarkdownView/index.tsx(+4 -0)➕
src/shared/components/molecules/Image/ExpandableImage.tsx(+105 -0)➕
src/shared/components/molecules/Image/ImagePreview.tsx(+27 -0)📝
src/shared/components/organisms/Modal/index.tsx(+4 -0)📝
src/shared/lib/stores/modal/types.ts(+2 -2)📄 Description
It is also a feature in WebApp but we can remove it from there if needed only in Desktop App.
Usage instructions:
Click on preview image to enlarge it
Click on enlarge button which activates on image hover to enlarge it
Click Escape once in enlarged view to discard it (close)
Click on Close button next to image in top right corner to close the view
Short preview how it works:
https://user-images.githubusercontent.com/18196945/128878278-8c6b770b-e404-486d-a443-b81bb9558bea.mp4
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.