[PR #34] [MERGED] Fallback DNS => HTTP (self-hosted) when DNS test fails #47

New issue

Closed

opened 2026-02-26 21:31:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:31:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ridercz/AutoACME/pull/34
Author: @avonwyss
Created: 11/28/2018
Status: ✅ Merged
Merged: 11/28/2018
Merged by: @ridercz

Base: master ← Head: fallback

📝 Commits (4)

720995b Introduced support for fallback DNS => HTTP (self-hosted) when DNS test fails
c1d783d Changed challenge retry defaults to accomodate for DNS delays
ca8da42 Replaved Trace.Xxx calls with own Log.Xxx calls since Trace does not play well with async (indentation not captures in context), and ConfigureAsync(true) due to WMI issues
0eabe00 Fix System.Net.Http binding redirects

📊 Changes

22 files changed (+536 additions, -457 deletions)

View changed files

📝 Altairis.AutoAcme.Configuration/Store.cs (+2 -2)
📝 Altairis.AutoAcme.Configuration/app.config (+1 -1)
📝 Altairis.AutoAcme.Core/AcmeEnvironment.cs (+17 -34)
📝 Altairis.AutoAcme.Core/Altairis.AutoAcme.Core.csproj (+5 -0)
📝 Altairis.AutoAcme.Core/AutoAcmeContext.cs (+36 -35)
📝 Altairis.AutoAcme.Core/CertificateRequestResult.cs (+47 -48)
📝 Altairis.AutoAcme.Core/Challenges/ChallengeResponseProvider.cs (+30 -26)
📝 Altairis.AutoAcme.Core/Challenges/DnsChallengeResponseProvider.cs (+30 -32)
➕ Altairis.AutoAcme.Core/Challenges/FallbackChallengeResponseProvider.cs (+51 -0)
📝 Altairis.AutoAcme.Core/Challenges/HttpChallengeFileResponseProvider.cs (+5 -6)
📝 Altairis.AutoAcme.Core/Challenges/HttpChallengeHostedResponseProvider.cs (+4 -5)
📝 Altairis.AutoAcme.Core/Challenges/HttpChallengeResponseProvider.cs (+31 -37)
➕ Altairis.AutoAcme.Core/Challenges/IChallengeResponseProvider.cs (+13 -0)
➕ Altairis.AutoAcme.Core/Log.cs (+69 -0)
📝 Altairis.AutoAcme.Core/app.config (+1 -1)
📝 Altairis.AutoAcme.IisSync/Altairis.AutoAcme.IisSync.csproj (+3 -3)
📝 Altairis.AutoAcme.IisSync/App.config (+1 -1)
📝 Altairis.AutoAcme.IisSync/Program.cs (+66 -60)
📝 Altairis.AutoAcme.IisSync/packages.config (+2 -2)
📝 Altairis.AutoAcme.Manager/Altairis.AutoAcme.Manager.csproj (+0 -2)

...and 2 more files

📄 Description

This allows to use both DNS and self-hosted HTTP challenges safely at the same time. When the DNS setup (CNAME or otherwise) does not match the expectation, HTTP is used. Documented in https://github.com/ridercz/AutoACME/wiki/AutoACME-in-a-web-farm-environment

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ridercz/AutoACME/pull/34 **Author:** [@avonwyss](https://github.com/avonwyss) **Created:** 11/28/2018 **Status:** ✅ Merged **Merged:** 11/28/2018 **Merged by:** [@ridercz](https://github.com/ridercz) **Base:** `master` ← **Head:** `fallback` --- ### 📝 Commits (4) - [`720995b`](https://github.com/ridercz/AutoACME/commit/720995b19e5afb0a58096cdbcc57ea023ed81a40) Introduced support for fallback DNS => HTTP (self-hosted) when DNS test fails - [`c1d783d`](https://github.com/ridercz/AutoACME/commit/c1d783d43c24f6b4d1ef58000b93e893f93cab51) Changed challenge retry defaults to accomodate for DNS delays - [`ca8da42`](https://github.com/ridercz/AutoACME/commit/ca8da42dd19d591df5ada88ca06eb6ef92f4a2a5) Replaved Trace.Xxx calls with own Log.Xxx calls since Trace does not play well with async (indentation not captures in context), and ConfigureAsync(true) due to WMI issues - [`0eabe00`](https://github.com/ridercz/AutoACME/commit/0eabe00fedb12204016012442f9ccd34802b3854) Fix System.Net.Http binding redirects ### 📊 Changes **22 files changed** (+536 additions, -457 deletions) <details> <summary>View changed files</summary> 📝 `Altairis.AutoAcme.Configuration/Store.cs` (+2 -2) 📝 `Altairis.AutoAcme.Configuration/app.config` (+1 -1) 📝 `Altairis.AutoAcme.Core/AcmeEnvironment.cs` (+17 -34) 📝 `Altairis.AutoAcme.Core/Altairis.AutoAcme.Core.csproj` (+5 -0) 📝 `Altairis.AutoAcme.Core/AutoAcmeContext.cs` (+36 -35) 📝 `Altairis.AutoAcme.Core/CertificateRequestResult.cs` (+47 -48) 📝 `Altairis.AutoAcme.Core/Challenges/ChallengeResponseProvider.cs` (+30 -26) 📝 `Altairis.AutoAcme.Core/Challenges/DnsChallengeResponseProvider.cs` (+30 -32) ➕ `Altairis.AutoAcme.Core/Challenges/FallbackChallengeResponseProvider.cs` (+51 -0) 📝 `Altairis.AutoAcme.Core/Challenges/HttpChallengeFileResponseProvider.cs` (+5 -6) 📝 `Altairis.AutoAcme.Core/Challenges/HttpChallengeHostedResponseProvider.cs` (+4 -5) 📝 `Altairis.AutoAcme.Core/Challenges/HttpChallengeResponseProvider.cs` (+31 -37) ➕ `Altairis.AutoAcme.Core/Challenges/IChallengeResponseProvider.cs` (+13 -0) ➕ `Altairis.AutoAcme.Core/Log.cs` (+69 -0) 📝 `Altairis.AutoAcme.Core/app.config` (+1 -1) 📝 `Altairis.AutoAcme.IisSync/Altairis.AutoAcme.IisSync.csproj` (+3 -3) 📝 `Altairis.AutoAcme.IisSync/App.config` (+1 -1) 📝 `Altairis.AutoAcme.IisSync/Program.cs` (+66 -60) 📝 `Altairis.AutoAcme.IisSync/packages.config` (+2 -2) 📝 `Altairis.AutoAcme.Manager/Altairis.AutoAcme.Manager.csproj` (+0 -2) _...and 2 more files_ </details> ### 📄 Description This allows to use both DNS and self-hosted HTTP challenges safely at the same time. When the DNS setup (CNAME or otherwise) does not match the expectation, HTTP is used. Documented in https://github.com/ridercz/AutoACME/wiki/AutoACME-in-a-web-farm-environment --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 21:31:31 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/AutoACME#47

No description provided.

Rows
Columns