[PR #33] [MERGED] ACME V2 and DNS challenge #46

Closed
opened 2026-02-26 21:31:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ridercz/AutoACME/pull/33
Author: @avonwyss
Created: 11/27/2018
Status: Merged
Merged: 11/28/2018
Merged by: @ridercz

Base: masterHead: dns


📝 Commits (5)

  • 62e2513 Added support for IDN #31
  • c1854c0 Replaced local server URL constants with Certes constants
  • 9ef6e18 Converted code to ACME V2 protocol, and implemented DNS challenge support (requires Windows DNS Server for catch-all domain)
  • 509adbf Added support for multiple names (space or comma-separated) in host entries, which then request a SAN certificate
  • 57ff58c Added support for wildcard certificates

📊 Changes

26 files changed (+1518 additions, -1212 deletions)

View changed files

📝 Altairis.AutoAcme.Configuration/Altairis.AutoAcme.Configuration.csproj (+4 -4)
📝 Altairis.AutoAcme.Configuration/Store.cs (+13 -1)
📝 Altairis.AutoAcme.Configuration/app.config (+22 -22)
📝 Altairis.AutoAcme.Configuration/packages.config (+13 -13)
Altairis.AutoAcme.Core/AcmeContext.cs (+0 -284)
📝 Altairis.AutoAcme.Core/AcmeEnvironment.cs (+39 -33)
📝 Altairis.AutoAcme.Core/Altairis.AutoAcme.Core.csproj (+18 -7)
Altairis.AutoAcme.Core/AutoAcmeContext.cs (+154 -0)
📝 Altairis.AutoAcme.Core/CertificateRequestResult.cs (+3 -1)
Altairis.AutoAcme.Core/ChallengeFile.cs (+0 -23)
Altairis.AutoAcme.Core/ChallengeHosted.cs (+0 -56)
Altairis.AutoAcme.Core/Challenges/ChallengeResponseProvider.cs (+85 -0)
Altairis.AutoAcme.Core/Challenges/DnsChallengeResponseProvider.cs (+122 -0)
Altairis.AutoAcme.Core/Challenges/HttpChallengeFileResponseProvider.cs (+31 -0)
Altairis.AutoAcme.Core/Challenges/HttpChallengeHostedResponseProvider.cs (+72 -0)
Altairis.AutoAcme.Core/Challenges/HttpChallengeResponseProvider.cs (+123 -0)
📝 Altairis.AutoAcme.Core/app.config (+26 -22)
📝 Altairis.AutoAcme.Core/packages.config (+15 -13)
📝 Altairis.AutoAcme.IisSync/Altairis.AutoAcme.IisSync.csproj (+15 -1)
📝 Altairis.AutoAcme.IisSync/App.config (+37 -33)

...and 6 more files

📄 Description

This is a preparation for supporting wildcard hosts (which IIS 2016 now fully supports as well); see my comment in #17

  • Converted code to use ACME V2 protocol instead of V1
  • Refactored challenge handling
  • Added DNS challenge support with catch-all scheme
  • Added simple SAN support (multiple hostnames are allowed when manually adding a host)
  • Added certificate wildcard support

Migration from the current version and the HTTP-based challenges need some testing, but I think it should work fine.

Note: this PR includes the IDN changes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ridercz/AutoACME/pull/33 **Author:** [@avonwyss](https://github.com/avonwyss) **Created:** 11/27/2018 **Status:** ✅ Merged **Merged:** 11/28/2018 **Merged by:** [@ridercz](https://github.com/ridercz) **Base:** `master` ← **Head:** `dns` --- ### 📝 Commits (5) - [`62e2513`](https://github.com/ridercz/AutoACME/commit/62e25134447059025ee63eeb84a642cc0e49f45a) Added support for IDN #31 - [`c1854c0`](https://github.com/ridercz/AutoACME/commit/c1854c0bcdc422354dd26e1741d01850ffa3953f) Replaced local server URL constants with Certes constants - [`9ef6e18`](https://github.com/ridercz/AutoACME/commit/9ef6e1849b5de774c2aee71208f32ad35899c391) Converted code to ACME V2 protocol, and implemented DNS challenge support (requires Windows DNS Server for catch-all domain) - [`509adbf`](https://github.com/ridercz/AutoACME/commit/509adbf27bae0d1e95018514ae7aa5f0e2400ca0) Added support for multiple names (space or comma-separated) in host entries, which then request a SAN certificate - [`57ff58c`](https://github.com/ridercz/AutoACME/commit/57ff58c435c947a958110d152575770b13c6e840) Added support for wildcard certificates ### 📊 Changes **26 files changed** (+1518 additions, -1212 deletions) <details> <summary>View changed files</summary> 📝 `Altairis.AutoAcme.Configuration/Altairis.AutoAcme.Configuration.csproj` (+4 -4) 📝 `Altairis.AutoAcme.Configuration/Store.cs` (+13 -1) 📝 `Altairis.AutoAcme.Configuration/app.config` (+22 -22) 📝 `Altairis.AutoAcme.Configuration/packages.config` (+13 -13) ➖ `Altairis.AutoAcme.Core/AcmeContext.cs` (+0 -284) 📝 `Altairis.AutoAcme.Core/AcmeEnvironment.cs` (+39 -33) 📝 `Altairis.AutoAcme.Core/Altairis.AutoAcme.Core.csproj` (+18 -7) ➕ `Altairis.AutoAcme.Core/AutoAcmeContext.cs` (+154 -0) 📝 `Altairis.AutoAcme.Core/CertificateRequestResult.cs` (+3 -1) ➖ `Altairis.AutoAcme.Core/ChallengeFile.cs` (+0 -23) ➖ `Altairis.AutoAcme.Core/ChallengeHosted.cs` (+0 -56) ➕ `Altairis.AutoAcme.Core/Challenges/ChallengeResponseProvider.cs` (+85 -0) ➕ `Altairis.AutoAcme.Core/Challenges/DnsChallengeResponseProvider.cs` (+122 -0) ➕ `Altairis.AutoAcme.Core/Challenges/HttpChallengeFileResponseProvider.cs` (+31 -0) ➕ `Altairis.AutoAcme.Core/Challenges/HttpChallengeHostedResponseProvider.cs` (+72 -0) ➕ `Altairis.AutoAcme.Core/Challenges/HttpChallengeResponseProvider.cs` (+123 -0) 📝 `Altairis.AutoAcme.Core/app.config` (+26 -22) 📝 `Altairis.AutoAcme.Core/packages.config` (+15 -13) 📝 `Altairis.AutoAcme.IisSync/Altairis.AutoAcme.IisSync.csproj` (+15 -1) 📝 `Altairis.AutoAcme.IisSync/App.config` (+37 -33) _...and 6 more files_ </details> ### 📄 Description This is a preparation for supporting wildcard hosts (which IIS 2016 now fully supports as well); see my comment in #17 * Converted code to use ACME V2 protocol instead of V1 * Refactored challenge handling * Added DNS challenge support with catch-all scheme * Added simple SAN support (multiple hostnames are allowed when manually adding a host) * Added certificate wildcard support Migration from the current version and the HTTP-based challenges need some testing, but I think it should work fine. Note: this PR includes the IDN changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 21:31:31 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AutoACME#46
No description provided.