mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1513] Bug: Scheduled archiving ignores environment variables for archiving methods in docker-compose.yml #892
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#892
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @simmeringdeacon on GitHub (Sep 8, 2024).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1513
Describe the bug
Steps to reproduce
docker compose up.Screenshots or log output
Excerpt from schedule.log showing disabled methods being used:
Excerpt from the terminal output showing a cron job:
ArchiveBox version
@pirate commented on GitHub (Sep 8, 2024):
This is expected behavior as you don't have any environment variables set on the scheduling container. You only set them in the primary container (they only apply to the container they are set on).
If you want to share config between containers you should put those in
ArchiveBox.confinstead of environment variables, or you could copy paste your environment section onto both.In general environment varibles usually only apply the processes that have them in their scope, I wouldn't want processes to copy the env they're getting and try to force-apply it to their sibling processes that have a different env.
@simmeringdeacon commented on GitHub (Sep 8, 2024):
Would it be possible to make this more obvious in https://github.com/ArchiveBox/ArchiveBox/wiki/Docker#configuration and/or "Caveats - Archiving Private Content" section of https://archivebox.io/? This was not immediately obvious to me, even after thoroughly reading the documentation, and it was only after testing for a day that I realized save_archive_dot_org was still being triggered accidentally.
I ended up tweaking the codebase myself to prevent this from happening, but I believe it would be beneficial to a wider user base if this caveat were made clearer in the official documentation.
@pirate commented on GitHub (Sep 9, 2024):
I could add more, but it's explained in a few places already: https://github.com/ArchiveBox/ArchiveBox/wiki/Docker#configuration
I understand it can be confusing if you're new to Docker but I don't want to necessarily make my docs a thorough re-introduction to all of Docker's ideosyncrasies. I do expect people to learn Docker to some degree if they are using the Docker install method 🤷