mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1369] Feature Request: Add new generic_jsonl parser to support ingesting JSONL #838
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#838
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jimwins on GitHub (Mar 1, 2024).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1369
Type
What is the problem that your feature request solves
JSONL is not supported.
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
This should be a fairly simple addition to the
generic_jsonparser. When the file fails to parse withjson.parse(), try again to parse it as JSONL before trying the case that skips the first line.How badly do you want this new feature?
@pirate commented on GitHub (Mar 1, 2024):
Maybe we can do it as a separate parser?
generic_jsonlI think making the parsers more narrow and explicit and having more of them is likely a better approach going forward to avoid the issues we've had in the past with trying to cram a bunch of workaround behaviors into a single parser.
@jimwins commented on GitHub (Mar 1, 2024):
Yeah, now that I play around with it we do need it to be a distinct parser because a single-line JSONL is a valid JSON file but not in the format that the
generic_jsonparser expects. The two parsers can share code for turning each JSON object into aLinkso that doesn't get duplicated, at least.@pirate commented on GitHub (Mar 22, 2024):
Closing as completed, thanks @jimwins!