mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1122] Feature Request: Explicitly specify --headless=new #704
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#704
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fa0311 on GitHub (Mar 16, 2023).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1122
Type
What is the problem that your feature request solves
Resolve the problem of unstable headless mode in the current chromium v111.
For example, it can solve the problem of
RESOLUTION(--window-size) not working.Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes
Change the argument given to chromium to
--headless=newNote
/usr/bin/chromium-browser --headless --timeout=2000 --screenshot --window-size=1440,2000 https://github.com/ArchiveBox//usr/bin/chromium-browser --headless=new --timeout=2000 --screenshot --window-size=1440,2000 https://github.com/ArchiveBox/@pirate commented on GitHub (Mar 16, 2023):
Want to open a PR so you get the credit 😉 ? I'm also happy to do it
We just have to add a version check and if the version is >= 111 change the argument
@pirate commented on GitHub (Jun 13, 2023):
closing because PR was merged, thanks again!