mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #1003] Bug: CHROME_BINARY config ignored by Docker container #630
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#630
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @agnosticlines on GitHub (Jul 24, 2022).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/1003
Describe the bug
If you set the chrome binary in the
ArchiveBox.conffile, the changes are ignored when running with DockerSteps to reproduce
ArchiveBox.conf:The code does take the config into account (from ArchiveBox/extractors/singlefile.py:47)
But I guess the Dockerfile overwrites that, so you have to set it in the dockerfile or docker compose environment variables, this isn't super clear and may confuse new users
@pirate commented on GitHub (Jul 26, 2022):
How exactly are you running a non-standard chromium binary in the Docker image? Are you using a custom Dockerfile or loading a custom executable via a volume?
@agnosticlines commented on GitHub (Jul 26, 2022):
I'm not, I was trying to find a workaround for the
/usr/bin/chromiumlink that you added to the dockerfile, when I was doing it though I noticed this option wasn't respected, it may not be important and looking back on it this option probably only makes sense on a normal install not a dockerized one.My bad!