mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #981] Enhancement: Add SINGLEFILE_ARGS to pass custom CLI args to singlefile #608
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#608
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @renaisun on GitHub (May 23, 2022).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/981
I see there're
WGET_ARGSandCURL_ARGSin config.py passed to corresponding binaries. But I don't find a way to customize the options passed to singlefile binary. Is there any way to do so?@renaisun commented on GitHub (May 24, 2022):
As what I see in singlefile.py, the arguments passed to the executable are
--browser-executable-pathand--browser-args.Maybe the only thing to do is to pass all available arguments in single-file? But I have no idea about how to implement it in a programmatic way since the available arguments are based on the version of single-file.
@pirate commented on GitHub (Jun 9, 2022):
Ah sorry looks like we still need to add
SINGLEFILE_ARGSand make sure it plays nicely withCHROME_ARGS. This will be a TODO for the next release. Contributors welcome.Sub-tasks:
SINGLEFILE_ARGStoarchivebox/config.pySINGLEFILE_ARGStoarchivebox/extractors/singlefile.pyrun()callSINGLEFILE_ARGSin https://github.com/ArchiveBox/ArchiveBox/wiki/Configuration#dependency-options (and the other*_ARGSoptions while we're at it)@renaisun commented on GitHub (Jun 9, 2022):
@pirate Hi, just tried to add the
SINGLEFILE_ARGS. Could you please check commit? Also, I've updated the wiki page of*_ARGS@pirate commented on GitHub (Jan 19, 2024):
Closing as done! https://github.com/ArchiveBox/ArchiveBox/pull/1021 thanks @notevenaperson