starred/ArchiveBox

Fork 0

mirror of https://github.com/ArchiveBox/ArchiveBox.git synced 2026-04-25 09:06:02 +03:00

[GH-ISSUE #897] Question: Do we really need healthcheck? #557

New issue

Closed

opened 2026-03-01 14:44:33 +03:00 by kerem · 4 comments

kerem commented

2026-03-01 14:44:33 +03:00

Owner

Originally created by @upsuper on GitHub (Nov 27, 2021).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/897

Today I noticed that my disk write rate increased over the past months, and when I investigated, I found Docker did a large amount of disk write, which was seemingly from regularly writing config.v2.json in the directory of ArchiveBox container. When I inspected that file, I found that there are logs for healthcheck, and the container has been in unhealthy state for a long time because I changed the service port of the container in docker-compose.yml. I tried bringing it back to healthy state by changing the port back, but the problem was still there, and the disk write rate I could see at that point was ~15MB per 30s. Eventually I disabled healthcheck in docker-compose.yml and this problem stops.

There are two observations:

the unhealthy state had been there for a long time, and nothing ever brought that up to me
the healthcheck may produce large disk write

So I wonder whether it's really meaningful to have the healthcheck at all. It doesn't seem to be useful that it can inform users if something goes wrong, and it seems to be wasting resources. Should we drop it? Or disable it by default in the provided docker-compose.yml?

Originally created by @upsuper on GitHub (Nov 27, 2021). Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/897 Today I noticed that my disk write rate increased over the past months, and when I investigated, I found Docker did a large amount of disk write, which was seemingly from regularly writing `config.v2.json` in the directory of ArchiveBox container. When I inspected that file, I found that there are logs for healthcheck, and the container has been in unhealthy state for a long time because I changed the service port of the container in `docker-compose.yml`. I tried bringing it back to healthy state by changing the port back, but the problem was still there, and the disk write rate I could see at that point was ~15MB per 30s. Eventually I disabled healthcheck in `docker-compose.yml` and this problem stops. There are two observations: * the unhealthy state had been there for a long time, and nothing ever brought that up to me * the healthcheck may produce large disk write So I wonder whether it's really meaningful to have the healthcheck at all. It doesn't seem to be useful that it can inform users if something goes wrong, and it seems to be wasting resources. Should we drop it? Or disable it by default in the provided `docker-compose.yml`?

kerem closed this issue

2026-03-01 14:44:33 +03:00

kerem commented

2026-03-01 14:44:34 +03:00

Author

Owner

@pirate commented on GitHub (Nov 30, 2021):

huh I don't see any healthcheck enabled in https://github.com/ArchiveBox/ArchiveBox/blob/dev/docker-compose.yml, I explicitly don't add those and leave them to the user to configure if they need it.

@pirate commented on GitHub (Nov 30, 2021): huh I don't see any healthcheck enabled in https://github.com/ArchiveBox/ArchiveBox/blob/dev/docker-compose.yml, I explicitly don't add those and leave them to the user to configure if they need it.

kerem commented

2026-03-01 14:44:34 +03:00

Author

Owner

@upsuper commented on GitHub (Nov 30, 2021):

My guess would be that if the Dockerfile contains healthcheck, it's enabled by default, unless it's overridden in docker-compose.yml. If the intention is that it's left to user, maybe the compose file should have it disabled with a comment?

@upsuper commented on GitHub (Nov 30, 2021): My guess would be that if the `Dockerfile` contains healthcheck, it's enabled by default, unless it's overridden in `docker-compose.yml`. If the intention is that it's left to user, maybe the compose file should have it disabled with a comment?

kerem commented

2026-03-01 14:44:34 +03:00

Author

Owner

@mAAdhaTTah commented on GitHub (Nov 30, 2021):

Healthcheck is configured here.

@mAAdhaTTah commented on GitHub (Nov 30, 2021): Healthcheck is configured [here](https://github.com/ArchiveBox/ArchiveBox/blob/dev/Dockerfile#L122-L123).

kerem commented

2026-03-01 14:44:34 +03:00

Author

Owner

@pirate commented on GitHub (Dec 3, 2021):

ah right, that's really old. commented it out: github.com/ArchiveBox/ArchiveBox@b40a1e19d1

@pirate commented on GitHub (Dec 3, 2021): ah right, that's really old. commented it out: https://github.com/ArchiveBox/ArchiveBox/commit/b40a1e19d1a5c34f3c88e5b1e377fd93e6ef774a

kerem referenced this issue

2026-03-01 17:54:25 +03:00

[GH-ISSUE #557] Re-running archivebox init loses metadata #1863

kerem referenced this issue

2026-03-14 22:29:00 +03:00

[GH-ISSUE #557] Re-running archivebox init loses metadata #3374

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#557

No description provided.

Rows
Columns