mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 17:16:00 +03:00
[GH-ISSUE #67] links generated with incorrect folder #48
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#48
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @danhimalplanet on GitHub (Jan 31, 2018).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/67
I have a simple bookmark export file containing 1 url
https://gist.github.com/danhimalplanet/444a7bc30b34d249d4429527c78f5792
➜ ./archive.py ~/Downloads/bookmarks_1_30_18.html 2>&1 >/dev/null
➜ echo $?
0
this generates 'html/archive/index.html' https://gist.github.com/danhimalplanet/ac212bc2cd0047807ede39ba20934330
the generated index.html has relative links like:
'html/archive/archive/1517380882/screenshot.png'
the screenshot relative link is:
'html/archive/archive/1517380882/screenshot.png'
There is an extra 'archive' in the 2 links.
I can make this work if I symlink a directory 'archive' in 'html/archive' to point 1 directory up from 'html/archive'. That seems like a hack, or I'm doing something wrong.
@pirate commented on GitHub (Feb 12, 2018):
Thanks for reporting this, I'm probably just doing a bad path concatenation somewhere.
@InconsolableCellist commented on GitHub (Apr 1, 2018):
I have the same issue. The files generate properly but they're linked improperly, though it doesn't affect the PDF and screenshot links. I also see a png file that has a .png.html extension in the link
@InconsolableCellist commented on GitHub (Apr 1, 2018):
As a workaround to the ./archive problem I made a symlink in the local dir to ./archive, but this only seems to work some of the time, maybe? I didn't dig deep yet, there were a few issues I was having at once.
@pirate commented on GitHub (Apr 17, 2018):
Found and fixed as of:
1776bdfPlease pull and let me know if it works!
(Make sure to back up your archive beforehand in case anything gets messed up, this is still BETA code)