[PR #1752] [MERGED] Remove redundant chrome_validate hook, rename wget_validate to wget_i… #4517

New issue

Closed

opened 2026-03-15 01:48:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:48:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1752
Author: @pirate
Created: 12/31/2025
Status: ✅ Merged
Merged: 1/1/2026
Merged by: @pirate

Base: dev ← Head: claude/cleanup-on-crawl-hooks-TtLF6

📝 Commits (2)

4d33084 Remove redundant chrome_validate hook, rename wget_validate to wget_install
09a1ca3 Fix hook priority conflicts and standardize on_Binary naming

📊 Changes

12 files changed (+0 additions, -172 deletions)

View changed files

📝 archivebox/plugins/apt/on_Binary__13_apt_install.py (+0 -0)
📝 archivebox/plugins/brew/on_Binary__12_brew_install.py (+0 -0)
➖ archivebox/plugins/chrome/on_Crawl__10_chrome_validate.py (+0 -172)
📝 archivebox/plugins/custom/on_Binary__14_custom_install.py (+0 -0)
📝 archivebox/plugins/env/on_Binary__15_env_install.py (+0 -0)
📝 archivebox/plugins/htmltotext/on_Snapshot__58_htmltotext.py (+0 -0)
📝 archivebox/plugins/mercury/on_Snapshot__57_mercury.py (+0 -0)
📝 archivebox/plugins/npm/on_Binary__10_npm_install.py (+0 -0)
📝 archivebox/plugins/pip/on_Binary__11_pip_install.py (+0 -0)
📝 archivebox/plugins/readability/on_Snapshot__56_readability.py (+0 -0)
📝 archivebox/plugins/staticfile/on_Snapshot__32_staticfile.bg.js (+0 -0)
📝 archivebox/plugins/wget/on_Crawl__06_wget_install.py (+0 -0)

📄 Description

…nstall

Delete chrome/on_Crawl__10_chrome_validate.py (duplicates chrome_install)
Rename wget/on_Crawl__11_wget_validate.py → on_Crawl__06_wget_install.py

All hooks now follow consistent naming: install, launch, or config

Summary

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

Summary by cubic

Removed the redundant Chrome validate hook, renamed the Wget validate hook to wget_install, and standardized hook names and priorities to match the install/launch/config lifecycle. This removes duplicate logic and fixes priority conflicts across Crawl, Binary, and Snapshot hooks.

Refactors
- Deleted chrome/on_Crawl__10_chrome_validate.py (dup of chrome_install)
- Renamed wget validate to on_Crawl__06_wget_install.py
- Standardized on_Binary hook priorities: npm 10, pip 11, brew 12, apt 13, custom 14, env 15
- Fixed on_Snapshot order: staticfile 32, readability 56, mercury 57, htmltotext 58

^{Written for commit 09a1ca3134. Summary will update on new commits.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1752 **Author:** [@pirate](https://github.com/pirate) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 1/1/2026 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `claude/cleanup-on-crawl-hooks-TtLF6` --- ### 📝 Commits (2) - [`4d33084`](https://github.com/ArchiveBox/ArchiveBox/commit/4d330844967fea63d692b94803be07422ff06ea3) Remove redundant chrome_validate hook, rename wget_validate to wget_install - [`09a1ca3`](https://github.com/ArchiveBox/ArchiveBox/commit/09a1ca3134847b47ca71576506cbac9c67a360ae) Fix hook priority conflicts and standardize on_Binary naming ### 📊 Changes **12 files changed** (+0 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/plugins/apt/on_Binary__13_apt_install.py` (+0 -0) 📝 `archivebox/plugins/brew/on_Binary__12_brew_install.py` (+0 -0) ➖ `archivebox/plugins/chrome/on_Crawl__10_chrome_validate.py` (+0 -172) 📝 `archivebox/plugins/custom/on_Binary__14_custom_install.py` (+0 -0) 📝 `archivebox/plugins/env/on_Binary__15_env_install.py` (+0 -0) 📝 `archivebox/plugins/htmltotext/on_Snapshot__58_htmltotext.py` (+0 -0) 📝 `archivebox/plugins/mercury/on_Snapshot__57_mercury.py` (+0 -0) 📝 `archivebox/plugins/npm/on_Binary__10_npm_install.py` (+0 -0) 📝 `archivebox/plugins/pip/on_Binary__11_pip_install.py` (+0 -0) 📝 `archivebox/plugins/readability/on_Snapshot__56_readability.py` (+0 -0) 📝 `archivebox/plugins/staticfile/on_Snapshot__32_staticfile.bg.js` (+0 -0) 📝 `archivebox/plugins/wget/on_Crawl__06_wget_install.py` (+0 -0) </details> ### 📄 Description …nstall - Delete chrome/on_Crawl__10_chrome_validate.py (duplicates chrome_install) - Rename wget/on_Crawl__11_wget_validate.py → on_Crawl__06_wget_install.py All hooks now follow consistent naming: install, launch, or config  # Summary  # Related issues  # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk  --- ## Summary by cubic Removed the redundant Chrome validate hook, renamed the Wget validate hook to wget_install, and standardized hook names and priorities to match the install/launch/config lifecycle. This removes duplicate logic and fixes priority conflicts across Crawl, Binary, and Snapshot hooks. - **Refactors** - Deleted chrome/on_Crawl__10_chrome_validate.py (dup of chrome_install) - Renamed wget validate to on_Crawl__06_wget_install.py - Standardized on_Binary hook priorities: npm 10, pip 11, brew 12, apt 13, custom 14, env 15 - Fixed on_Snapshot order: staticfile 32, readability 56, mercury 57, htmltotext 58 <sup>Written for commit 09a1ca3134847b47ca71576506cbac9c67a360ae. Summary will update on new commits.</sup>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:48:46 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4517

No description provided.

Rows
Columns