[PR #1739] [MERGED] Change hook timeout enforcement strategy #4505

New issue

Closed

opened 2026-03-15 01:48:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:48:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1739
Author: @pirate
Created: 12/31/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @pirate

Base: dev ← Head: claude/refactor-hook-timeouts-pT0PM

📝 Commits (2)

b73199b Refactor background hook cleanup to use graceful termination
524e8e9 Capture exit codes and stderr from background hooks

📊 Changes

2 files changed (+228 additions, -11 deletions)

View changed files

📝 archivebox/core/models.py (+51 -11)
📝 archivebox/hooks.py (+177 -0)

📄 Description

Summary

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

Summary by cubic

Switch background hook cleanup to a graceful termination flow using plugin-specific timeouts, only SIGKILLing if needed. This improves reliability and records accurate exit codes and stderr for better result reporting.

Refactors
- Added graceful_terminate_background_hooks(): send SIGTERM to all hooks, wait per plugin timeout, SIGKILL remaining, reap with waitpid, write .returncode files.
- Snapshot.cleanup() now uses merged config (get_config) to apply plugin-specific timeouts and terminate hooks gracefully.
- update_from_output() reads .returncode and .stderr.log, infers status when no JSONL (handles signals like -9/-15), includes stderr on failures, and cleans up .returncode files.

^{Written for commit 524e8e98c3. Summary will update on new commits.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1739 **Author:** [@pirate](https://github.com/pirate) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `claude/refactor-hook-timeouts-pT0PM` --- ### 📝 Commits (2) - [`b73199b`](https://github.com/ArchiveBox/ArchiveBox/commit/b73199b33e7af040afee68d4c6759835ba06a625) Refactor background hook cleanup to use graceful termination - [`524e8e9`](https://github.com/ArchiveBox/ArchiveBox/commit/524e8e98c32fe773b40ad3e4e5098e22f8fe4d3c) Capture exit codes and stderr from background hooks ### 📊 Changes **2 files changed** (+228 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/core/models.py` (+51 -11) 📝 `archivebox/hooks.py` (+177 -0) </details> ### 📄 Description  # Summary  # Related issues  # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk  --- ## Summary by cubic Switch background hook cleanup to a graceful termination flow using plugin-specific timeouts, only SIGKILLing if needed. This improves reliability and records accurate exit codes and stderr for better result reporting. - **Refactors** - Added graceful_terminate_background_hooks(): send SIGTERM to all hooks, wait per plugin timeout, SIGKILL remaining, reap with waitpid, write .returncode files. - Snapshot.cleanup() now uses merged config (get_config) to apply plugin-specific timeouts and terminate hooks gracefully. - update_from_output() reads .returncode and .stderr.log, infers status when no JSONL (handles signals like -9/-15), includes stderr on failures, and cleans up .returncode files. <sup>Written for commit 524e8e98c32fe773b40ad3e4e5098e22f8fe4d3c. Summary will update on new commits.</sup>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:48:14 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4505

No description provided.

Rows
Columns