[PR #1649] [MERGED] Kill the timer process if it doesn't properly terminate. #4476

New issue

Closed

opened 2026-03-15 01:46:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:46:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1649
Author: @benmuth
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @pirate

Base: dev ← Head: progress-bar-hang

📝 Commits (2)

9f4cf0a Kill the timer process if it doesn't properly terminate.
71c02ca Update archivebox/misc/logging_util.py

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 archivebox/misc/logging_util.py (+7 -1)

📄 Description

Summary

This tries to fix the problem described in #1646. I ended up using kill() instead of the solution presented there because it turns out the behavior varied from run to run, and I couldn't get that solution to work consistently. Sending a kill signal was the simplest and most consistent fix. There may be some downsides I'm missing.

#1646

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1649 **Author:** [@benmuth](https://github.com/benmuth) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `progress-bar-hang` --- ### 📝 Commits (2) - [`9f4cf0a`](https://github.com/ArchiveBox/ArchiveBox/commit/9f4cf0a8e18d2d164d5857c4f85325166afddfa4) Kill the timer process if it doesn't properly terminate. - [`71c02ca`](https://github.com/ArchiveBox/ArchiveBox/commit/71c02ca4ebef208dc823437c0f9a56816b4141e5) Update archivebox/misc/logging_util.py ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/misc/logging_util.py` (+7 -1) </details> ### 📄 Description  # Summary This tries to fix the problem described in #1646. I ended up using `kill()` instead of the solution presented there because it turns out the behavior varied from run to run, and I couldn't get that solution to work consistently. Sending a kill signal was the simplest and most consistent fix. There may be some downsides I'm missing.  # Related issues #1646  # Changes these areas - [x] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:46:37 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4476

No description provided.

Rows
Columns