[PR #1534] [MERGED] Cleanup of new plugin system to remove unecessary pydantic complexity #4460

New issue

Closed

opened 2026-03-15 01:45:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:45:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1534
Author: @pirate
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @pirate

Base: dev ← Head: newmodels

📝 Commits (10+)

ad46578 add new crawls app
518c46b fix circular import and show log of plugins loading on startup
4634cd6 make should_extract take config and uri as args
a7c19a5 add register_admin to abx hookspec
b3b2c55 fix get_sock_file symlink process
536a5ea clear up Machine models cache vars
f75ae80 comment out Crawl api methods temporarily
a0bef4e move crawl model out of core
5ac941c resolve circular import in core/views
9a04ed7 move serve_static and shell_welcome_message into misc

📊 Changes

185 files changed (+5509 additions, -3804 deletions)

View changed files

📝 Dockerfile (+6 -1)
📝 README.md (+1 -1)
➕ archivebox/Architecture.md (+172 -0)
📝 archivebox/__init__.py (+1 -1)
📝 archivebox/abid_utils/admin.py (+4 -3)
📝 archivebox/abid_utils/models.py (+38 -0)
📝 archivebox/abx/__init__.py (+47 -6)
📝 archivebox/abx/archivebox/__init__.py (+8 -18)
➖ archivebox/abx/archivebox/base_admindataview.py (+0 -38)
📝 archivebox/abx/archivebox/base_binary.py (+10 -10)
📝 archivebox/abx/archivebox/base_configset.py (+128 -56)
📝 archivebox/abx/archivebox/base_extractor.py (+5 -7)
➖ archivebox/abx/archivebox/base_hook.py (+0 -80)
➖ archivebox/abx/archivebox/base_plugin.py (+0 -154)
➖ archivebox/abx/archivebox/base_queue.py (+0 -106)
📝 archivebox/abx/archivebox/base_replayer.py (+1 -5)
📝 archivebox/abx/archivebox/base_searchbackend.py (+7 -15)
➕ archivebox/abx/archivebox/effects.py (+20 -0)
➕ archivebox/abx/archivebox/events.py (+45 -0)
📝 archivebox/abx/archivebox/hookspec.py (+30 -13)

...and 80 more files

📄 Description

Moves away form earlier Pydantic style plugin system to new simpler flat Pluggy methods.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1534 **Author:** [@pirate](https://github.com/pirate) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `newmodels` --- ### 📝 Commits (10+) - [`ad46578`](https://github.com/ArchiveBox/ArchiveBox/commit/ad4657861f7b4baf006a3195be222b3c7f3f8b9d) add new crawls app - [`518c46b`](https://github.com/ArchiveBox/ArchiveBox/commit/518c46b4ab7332dcd1232dc87b749d70a82090a5) fix circular import and show log of plugins loading on startup - [`4634cd6`](https://github.com/ArchiveBox/ArchiveBox/commit/4634cd6c8e47738087fae548e90a2160afdabaab) make should_extract take config and uri as args - [`a7c19a5`](https://github.com/ArchiveBox/ArchiveBox/commit/a7c19a5da02cd8b1f686039d418cb1ddb587b973) add register_admin to abx hookspec - [`b3b2c55`](https://github.com/ArchiveBox/ArchiveBox/commit/b3b2c551c24179769b76ddebb8ac66b732cf5bf0) fix get_sock_file symlink process - [`536a5ea`](https://github.com/ArchiveBox/ArchiveBox/commit/536a5ea745d673ed1801b5fde718bd77596b9211) clear up Machine models cache vars - [`f75ae80`](https://github.com/ArchiveBox/ArchiveBox/commit/f75ae805f82c50c3ba0d49c8a62b15e43cb40c10) comment out Crawl api methods temporarily - [`a0bef4e`](https://github.com/ArchiveBox/ArchiveBox/commit/a0bef4e27b58ec88ff1c92641099688dcca1ed26) move crawl model out of core - [`5ac941c`](https://github.com/ArchiveBox/ArchiveBox/commit/5ac941cf2e262dc73ec8e6d9d32dc6231450c26d) resolve circular import in core/views - [`9a04ed7`](https://github.com/ArchiveBox/ArchiveBox/commit/9a04ed7c76aed09ccd9ea1573ccbadd23e5549cf) move serve_static and shell_welcome_message into misc ### 📊 Changes **185 files changed** (+5509 additions, -3804 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+6 -1) 📝 `README.md` (+1 -1) ➕ `archivebox/Architecture.md` (+172 -0) 📝 `archivebox/__init__.py` (+1 -1) 📝 `archivebox/abid_utils/admin.py` (+4 -3) 📝 `archivebox/abid_utils/models.py` (+38 -0) 📝 `archivebox/abx/__init__.py` (+47 -6) 📝 `archivebox/abx/archivebox/__init__.py` (+8 -18) ➖ `archivebox/abx/archivebox/base_admindataview.py` (+0 -38) 📝 `archivebox/abx/archivebox/base_binary.py` (+10 -10) 📝 `archivebox/abx/archivebox/base_configset.py` (+128 -56) 📝 `archivebox/abx/archivebox/base_extractor.py` (+5 -7) ➖ `archivebox/abx/archivebox/base_hook.py` (+0 -80) ➖ `archivebox/abx/archivebox/base_plugin.py` (+0 -154) ➖ `archivebox/abx/archivebox/base_queue.py` (+0 -106) 📝 `archivebox/abx/archivebox/base_replayer.py` (+1 -5) 📝 `archivebox/abx/archivebox/base_searchbackend.py` (+7 -15) ➕ `archivebox/abx/archivebox/effects.py` (+20 -0) ➕ `archivebox/abx/archivebox/events.py` (+45 -0) 📝 `archivebox/abx/archivebox/hookspec.py` (+30 -13) _...and 80 more files_ </details> ### 📄 Description Moves away form earlier Pydantic style plugin system to new simpler flat Pluggy methods. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:45:48 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4460

No description provided.

Rows
Columns