[PR #1457] [MERGED] Implement searching individual fields #4443

New issue

Closed

opened 2026-03-15 01:44:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:44:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1457
Author: @sclu1034
Created: 6/19/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @pirate

Base: dev ← Head: feat/search-fields

📝 Commits (2)

10f0c4a Implement searching individual fields
75018ed Merge branch 'dev' into feat/search-fields

📊 Changes

2 files changed (+35 additions, -2 deletions)

View changed files

📝 archivebox/core/views.py (+26 -2)
📝 archivebox/templates/core/public_index.html (+9 -0)

📄 Description

Summary

This adds a rudimentary implementation of #1453.
So far, this only changes the search box on the public view, as the custom form and corresponding logic there were relatively simple to track down and change.
As far as I can tell, the one on the admin page uses Django's built-in functionality instead, and I didn't see any immediate way to change that logic.

The current list of supported fields is mostly just based on the placeholder in the search input, but adding more metadata fields should be trivial.
Another interesting change could be to have the Metadata option run ripgrep, but restricted to index.json via glob (or the equivalent for other backends), but that would require a change in the search backends' search() function signature.

#1453

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1457 **Author:** [@sclu1034](https://github.com/sclu1034) **Created:** 6/19/2024 **Status:** ✅ Merged **Merged:** 8/20/2024 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `feat/search-fields` --- ### 📝 Commits (2) - [`10f0c4a`](https://github.com/ArchiveBox/ArchiveBox/commit/10f0c4a0775e0c1e5a6d74b293b83e08f1de2244) Implement searching individual fields - [`75018ed`](https://github.com/ArchiveBox/ArchiveBox/commit/75018ed10b13d8209a54f0d1b28b3f88a4f42450) Merge branch 'dev' into feat/search-fields ### 📊 Changes **2 files changed** (+35 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/core/views.py` (+26 -2) 📝 `archivebox/templates/core/public_index.html` (+9 -0) </details> ### 📄 Description  # Summary This adds a rudimentary implementation of #1453. So far, this only changes the search box on the public view, as the custom form and corresponding logic there were relatively simple to track down and change. As far as I can tell, the one on the admin page uses Django's built-in functionality instead, and I didn't see any immediate way to change that logic. The current list of supported fields is mostly just based on the placeholder in the search input, but adding more metadata fields should be trivial. Another interesting change could be to have the `Metadata` option run ripgrep, but restricted to `index.json` via glob (or the equivalent for other backends), but that would require a change in the search backends' `search()` function signature. # Related issues #1453 # Changes these areas - [ ] Bugfixes - [x] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:44:59 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4443

No description provided.

Rows
Columns