[PR #1314] [MERGED] Show the upgrade notification only in specific views #4388

New issue

Closed

opened 2026-03-15 01:42:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:42:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/1314
Author: @benmuth
Created: 1/9/2024
Status: ✅ Merged
Merged: 1/23/2024
Merged by: @pirate

Base: dev ← Head: specific-version-banner

📝 Commits (2)

5de45db Show upgrade notification in admin snapshot view
d0cd84a Merge branch 'dev' into specific-version-banner

📊 Changes

2 files changed (+13 additions, -9 deletions)

View changed files

📝 archivebox/core/admin.py (+13 -1)
📝 archivebox/core/urls.py (+0 -8)

📄 Description

Summary

This PR adds back the upgrade notification banner that was originally added in #1274 and removed in 4af9bee, but only to specific views instead of the entire admin site, as discussed in #1306.

I wasn't sure for which views we should show the banner, so for now it's only showing on the snapshot view (the page at /admin/core/snapshot/.

The necessary context is provided by overriding the changelist_view method of the SnapshotAdmin model. I think this could work for all views except for the main admin page (/admin/). If we want to pass context to the view for that page, I think we can override the each_context method of ArchiveBoxAdmin instead.

#696

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/1314 **Author:** [@benmuth](https://github.com/benmuth) **Created:** 1/9/2024 **Status:** ✅ Merged **Merged:** 1/23/2024 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `specific-version-banner` --- ### 📝 Commits (2) - [`5de45db`](https://github.com/ArchiveBox/ArchiveBox/commit/5de45dbf30c277fd39c2c4388cdcae1f159efb6b) Show upgrade notification in admin snapshot view - [`d0cd84a`](https://github.com/ArchiveBox/ArchiveBox/commit/d0cd84a2af35592b2de3b8d58422c988580340a2) Merge branch 'dev' into specific-version-banner ### 📊 Changes **2 files changed** (+13 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/core/admin.py` (+13 -1) 📝 `archivebox/core/urls.py` (+0 -8) </details> ### 📄 Description  # Summary This PR adds back the upgrade notification banner that was originally added in #1274 and removed in 4af9bee, but only to specific views instead of the entire admin site, as discussed in #1306. I wasn't sure for which views we should show the banner, so for now it's only showing on the snapshot view (the page at `/admin/core/snapshot/`. The necessary context is provided by overriding the `changelist_view` method of the `SnapshotAdmin` model. I think this could work for all views except for the main admin page (`/admin/`). If we want to pass context to the view for that page, I think we can override the `each_context` method of `ArchiveBoxAdmin` instead.  # Related issues #696  # Changes these areas - [ ] Bugfixes - [x] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:42:01 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4388

No description provided.

Rows
Columns