mirror of
https://github.com/ArchiveBox/ArchiveBox.git
synced 2026-04-25 09:06:02 +03:00
[GH-ISSUE #696] Show banner to upgrade to latest version when ArchiveBox is out of date #436
Labels
No labels
expected: maybe someday
expected: next release
expected: release after next
expected: unlikely unless contributed
good first ticket
help wanted
pull-request
scope: all users
scope: windows users
size: easy
size: hard
size: medium
size: medium
status: backlog
status: blocked
status: done
status: idea-phase
status: needs followup
status: wip
status: wontfix
touches: API/CLI/Spec
touches: configuration
touches: data/schema/architecture
touches: dependencies/packaging
touches: docs
touches: js
touches: views/replayers/html/css
why: correctness
why: functionality
why: performance
why: security
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ArchiveBox#436
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pirate on GitHub (Apr 8, 2021).
Original GitHub issue: https://github.com/ArchiveBox/ArchiveBox/issues/696
Many people seem to be running older versions, which can lead to trouble when upgrading many versions at a time.
I'd like to nudge people towards upgrading more frequently by showing something in the UI.
Possibly using: https://github.com/releasepage/version.js
Conditions:
is_superuserThen:
0.7.0go to last minor version0.7.9, then +=1 1 major version at a time to0.8.9, then finally0.9.3latest versionarchivebox add/schedulejobs, show hint line in CLI stderr output if upgrade is available@benmuth commented on GitHub (Nov 26, 2023):
@pirate Couple of questions about the implementation for this:
@pirate commented on GitHub (Nov 26, 2023):
Ah just saw this, so unfortunately it has to be in Python not JS, because we need to show the warning in the CLI too, and I don't want every page request to phone home to GitHub so we'd want to do it once on startup of the server and just store it as a global config variable.
No need to store the result on disk or in a model, just check once in config.py and set the result in a variable e.g. LATEST_VERSION = "0.8.9". Then if LATEST_VERSION > VERSION show the CLI warning and a UI banner.
The hiding banner logic can be in JS (if user has hidden the banner, then store a var in their browser's localstorage to not show the banner again).