[PR #911] [MERGED] Added TAG_SEPARATOR_PATTERN option for splitting tags #4307

Closed
opened 2026-03-15 01:37:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/911
Author: @hannah98
Created: 12/30/2021
Status: Merged
Merged: 1/11/2022
Merged by: @pirate

Base: devHead: dev


📝 Commits (3)

  • 049f88d Added TAG_SEPARATORS option to supply a regex of characters to use when splitting tags
  • fc3d2bb rename TAG_SEPARATORS to TAG_SEPARATOR_PATTERN
  • 666ab20 Update archivebox/config.py

📊 Changes

3 files changed (+10 additions, -3 deletions)

View changed files

📝 archivebox/config.py (+1 -0)
📝 archivebox/config_stubs.py (+1 -0)
📝 archivebox/index/sql.py (+8 -3)

📄 Description

Summary

This PR adds the TAG_SEPARATOR_PATTERN option. This option is a regex character class that will be used when splitting the tag string.
It defaults to [,] which will split tags on commas. Splitting tags is currently done on commas so this will be backwards compatible and should not introduce breaking changes.

Some Examples:

  • Splitting on spaces: TAG_SEPARATOR_PATTERN="[ ]"
  • Splitting on spaces and commas: TAG_SEPARATOR_PATTERN="[ ,]"
  • Splitting on spaces, commas, and semicolons: TAG_SEPARATOR_PATTERN="[ ,;]"

  • All previously passing tests still pass.
  • I can give the Wiki text so that the Wiki page for the configuration can be updated with this new option.

Related issues

#725

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/911 **Author:** [@hannah98](https://github.com/hannah98) **Created:** 12/30/2021 **Status:** ✅ Merged **Merged:** 1/11/2022 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (3) - [`049f88d`](https://github.com/ArchiveBox/ArchiveBox/commit/049f88def984188b9ff49b169d3a27595f099936) Added TAG_SEPARATORS option to supply a regex of characters to use when splitting tags - [`fc3d2bb`](https://github.com/ArchiveBox/ArchiveBox/commit/fc3d2bb4dc01da73bb9fe068f3bc5e741083430d) rename TAG_SEPARATORS to TAG_SEPARATOR_PATTERN - [`666ab20`](https://github.com/ArchiveBox/ArchiveBox/commit/666ab20df576cc841c57b00e0821e219e4b84e37) Update archivebox/config.py ### 📊 Changes **3 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/config.py` (+1 -0) 📝 `archivebox/config_stubs.py` (+1 -0) 📝 `archivebox/index/sql.py` (+8 -3) </details> ### 📄 Description <!-- IMPORTANT: Do not submit PRs with only formatting / PEP8 / line length changes. --> # Summary This PR adds the ```TAG_SEPARATOR_PATTERN``` option. This option is a regex character class that will be used when splitting the tag string. It defaults to ```[,]``` which will split tags on commas. Splitting tags is currently done on commas so this will be backwards compatible and should not introduce breaking changes. Some Examples: * Splitting on spaces: ```TAG_SEPARATOR_PATTERN="[ ]"``` * Splitting on spaces and commas: ```TAG_SEPARATOR_PATTERN="[ ,]"``` * Splitting on spaces, commas, and semicolons: ```TAG_SEPARATOR_PATTERN="[ ,;]"``` --- * All previously passing tests still pass. * I can give the Wiki text so that the Wiki page for the configuration can be updated with this new option. <!--e.g. This PR fixes ABC or adds the ability to do XYZ...--> # Related issues #725 <!-- e.g. #123 or Roadmap goal # https://github.com/pirate/ArchiveBox/wiki/Roadmap --> # Changes these areas - [ ] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [x] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-15 01:37:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ArchiveBox#4307
No description provided.