[PR #908] [MERGED] Fix #725 - correctly parse tags on json import #4298

New issue

Closed

opened 2026-03-15 01:37:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:37:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/908
Author: @hannah98
Created: 12/20/2021
Status: ✅ Merged
Merged: 12/21/2021
Merged by: @pirate

Base: dev ← Head: dev

📝 Commits (1)

4b8962b Fix #725 - correctly parse tags on json import

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 archivebox/index/sql.py (+6 -3)

📄 Description

Summary

This PR fixes #725 - instead of tags being split on each character, this fix mimics a code block further down in the same file to create a list of tags first before calling the save_tags() method.

github.com/ArchiveBox/ArchiveBox@32764347ce/archivebox/index/sql.py (L107-L109)

#725

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/908 **Author:** [@hannah98](https://github.com/hannah98) **Created:** 12/20/2021 **Status:** ✅ Merged **Merged:** 12/21/2021 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`4b8962b`](https://github.com/ArchiveBox/ArchiveBox/commit/4b8962b60b1540729a048483e76af1f5563707a9) Fix #725 - correctly parse tags on json import ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/index/sql.py` (+6 -3) </details> ### 📄 Description  # Summary This PR fixes #725 - instead of tags being split on each character, this fix mimics a code block further down in the same file to create a list of tags first before calling the ```save_tags()``` method. https://github.com/ArchiveBox/ArchiveBox/blob/32764347ce2e59919f763c552bd3e250f49c2f5b/archivebox/index/sql.py#L107-L109 # Related issues #725 # Changes these areas - [x] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:37:09 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4298

No description provided.

Rows
Columns