[PR #885] [MERGED] Tweak JS so Safari can choose admin actions #4296

New issue

Closed

opened 2026-03-15 01:36:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 01:36:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ArchiveBox/ArchiveBox/pull/885
Author: @adamwolf
Created: 10/29/2021
Status: ✅ Merged
Merged: 11/12/2021
Merged by: @pirate

Base: dev ← Head: safari-admin-actions

📝 Commits (1)

83731f5 Tweak JS so Safari can choose admin actions

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 archivebox/templates/admin/base.html (+1 -1)

📄 Description

Summary

This PR lets Safari use the admin actions.

I ran into #658 today. I noticed that Safari was submitting both the empty option and the selected options back to the server. Digging into it, I was able to get Safari to deselect the --------- option by using '[selected]' as the selector.

I am not a Safari expert.

#658

Changes these areas

Bugfixes
Feature behavior
Command line interface
Configuration options
Internal architecture
Snapshot data layout on disk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ArchiveBox/ArchiveBox/pull/885 **Author:** [@adamwolf](https://github.com/adamwolf) **Created:** 10/29/2021 **Status:** ✅ Merged **Merged:** 11/12/2021 **Merged by:** [@pirate](https://github.com/pirate) **Base:** `dev` ← **Head:** `safari-admin-actions` --- ### 📝 Commits (1) - [`83731f5`](https://github.com/ArchiveBox/ArchiveBox/commit/83731f5a68544f612e0fca787ddc7b43d7d39ae6) Tweak JS so Safari can choose admin actions ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `archivebox/templates/admin/base.html` (+1 -1) </details> ### 📄 Description # Summary This PR lets Safari use the admin actions. I ran into #658 today. I noticed that Safari was submitting both the empty option and the selected options back to the server. Digging into it, I was able to get Safari to deselect the --------- option by using '[selected]' as the selector. I am not a Safari expert. # Related issues #658 # Changes these areas - [x] Bugfixes - [ ] Feature behavior - [ ] Command line interface - [ ] Configuration options - [ ] Internal architecture - [ ] Snapshot data layout on disk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-15 01:36:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ArchiveBox#4296

No description provided.

Rows
Columns